Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7599)

Unified Diff: chrome/common/safe_browsing/permission_report.proto

Issue 2178213003: Update RequestTrigger to GestureType in permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/safe_browsing/permission_report.proto
diff --git a/chrome/common/safe_browsing/permission_report.proto b/chrome/common/safe_browsing/permission_report.proto
index 9ad2bf55f62be3757b667bf83cf73cf0f3ff46d4..f09c5c3d403c2c81ea31481f532b0024483281f7 100644
--- a/chrome/common/safe_browsing/permission_report.proto
+++ b/chrome/common/safe_browsing/permission_report.proto
@@ -24,8 +24,8 @@ message PermissionReport {
// The platform.
optional PlatformType platform_type = 3;
- // When the request was initiated.
- repeated RequestTrigger request_trigger = 4;
+ // Whether the action was after a user gesture.
+ optional GestureType gesture = 4;
// The action the user took. Required.
optional Action action = 5;
@@ -43,11 +43,11 @@ message PermissionReport {
ANDROID_PLATFORM = 2;
}
- // Various request triggers we want to record, e.g. on page load.
- enum RequestTrigger {
- REQUEST_TRIGGER_UNSPECIFIED = 0;
- ONLOAD = 1;
- AFTER_GESTURE = 2;
+ // Whether the action occurred after a user gesture.
+ enum GestureType {
+ GESTURE_TYPE_UNSPECIFIED = 0;
+ GESTURE = 1;
+ NO_GESTURE = 2;
}
// User Permission Actions. This enum is intentionally different with
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698