chrome/browser/safe_browsing/ping_manager.h - Issue 2178213003: Update RequestTrigger to GestureType in permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ping_manager.h

Issue 2178213003: Update RequestTrigger to GestureType in permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/ping_manager.h

diff --git a/chrome/browser/safe_browsing/ping_manager.h b/chrome/browser/safe_browsing/ping_manager.h

index a5aa7d71a2e6d45dacd56ed9970c952f07890275..00beead64e5aaee18d2210a2988f1ca0be792976 100644

--- a/chrome/browser/safe_browsing/ping_manager.h

+++ b/chrome/browser/safe_browsing/ping_manager.h

@@ -14,6 +14,7 @@

#include "base/gtest_prod_util.h"

#include "base/macros.h"

+#include "chrome/browser/permissions/permission_request.h"

#include "chrome/browser/permissions/permission_uma_util.h"

#include "chrome/browser/safe_browsing/protocol_manager_helper.h"

#include "components/safe_browsing_db/hit_report.h"

@@ -69,7 +70,7 @@ class SafeBrowsingPingManager : public net::URLFetcherDelegate {

content::PermissionType permission,

PermissionAction action,

PermissionSourceUI source_ui,

- bool user_gesture);

+ PermissionRequestGestureType gesture_type);

private:

FRIEND_TEST_ALL_PREFIXES(SafeBrowsingPingManagerTest,

« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter_unittest.cc ('k') | chrome/browser/safe_browsing/ping_manager.cc » ('j') | no next file with comments »