Record metrics for permission prompt acceptance vs. user gesture.

Record metrics for permission prompt acceptance vs. user gesture.

These metrics will allow us to compare acceptance rates for permission
prompts based on whether the prompt had a user gesture or not.

BUG=614599
Committed: https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17
Cr-Commit-Position: refs/heads/master@{#407638}

[benwells, 2016-07-05 07:55:27]

benwells@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-07-06 00:28:48]

https://codereview.chromium.org/2124703002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_bubble_request_impl.cc (right):

https://codereview.chromium.org/2124703002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_bubble_request_impl.cc:24:
permission_type_(permission_type),
Shouldn't has_gesture_ be initialized in here?

[benwells, 2016-07-06 01:14:01]

https://codereview.chromium.org/2124703002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_bubble_request_impl.cc (right):

https://codereview.chromium.org/2124703002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_bubble_request_impl.cc:24:
permission_type_(permission_type),
On 2016/07/06 00:28:47, tsergeant wrote:
> Shouldn't has_gesture_ be initialized in here?

Yes, indeed it should! Done.

[tsergeant, 2016-07-06 01:29:29]

lgtm

[benwells, 2016-07-06 01:38:57]

benwells@chromium.org changed reviewers:
+ isherman@chromium.org

[benwells, 2016-07-06 01:39:30]

(meant to say, +isherman for histograms)

[Ilya Sherman, 2016-07-06 23:02:16]

histograms lgtm, though it's not quite clear to me what "has gesture" vs "no
gesture" means.  It might be worthwhile to clarify the semantics, e.g. "shown in
response to a user gesture" vs. "shown in response to something other than a
user gesture" (is that what it means?)

[Ilya Sherman, 2016-07-06 23:03:12]

Oh!  By the way, you might want to use histogram_suffixes elements to reduce the
amount of repetition in the histograms.xml file.  If you do so, I'd like to
quickly re-review to make sure that the usage looks right.

[benwells, 2016-07-22 04:48:24]

Patchset #4 (id:60001) has been deleted

[benwells, 2016-07-22 04:56:52]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 04:57:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 06:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 06:14:35]

Dry run: This issue passed the CQ dry run.

[benwells, 2016-07-25 07:31:34]

On 2016/07/06 23:03:12, Ilya Sherman wrote:
> Oh!  By the way, you might want to use histogram_suffixes elements to reduce
the
> amount of repetition in the histograms.xml file.  If you do so, I'd like to
> quickly re-review to make sure that the usage looks right.

OK - rebased and rejiggered to use suffixes. PTAL!

[Ilya Sherman, 2016-07-25 18:50:10]

On 2016/07/25 07:31:34, benwells wrote:
> On 2016/07/06 23:03:12, Ilya Sherman wrote:
> > Oh!  By the way, you might want to use histogram_suffixes elements to reduce
> the
> > amount of repetition in the histograms.xml file.  If you do so, I'd like to
> > quickly re-review to make sure that the usage looks right.
> 
> OK - rebased and rejiggered to use suffixes. PTAL!

Thanks!  LGTM =)

[benwells, 2016-07-25 22:07:22]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-07-25 22:07:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2124703002/#ps120001
(title: "wups")

[commit-bot: I haz the power, 2016-07-25 22:07:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 23:58:21]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-07-26 00:03:15]

Description was changed from

==========
Record metrics for permission prompt acceptance vs. user gesture.

These metrics will allow us to compare acceptance rates for permission
prompts based on whether the prompt had a user gesture or not.

BUG=614599
==========

to

==========
Record metrics for permission prompt acceptance vs. user gesture.

These metrics will allow us to compare acceptance rates for permission
prompts based on whether the prompt had a user gesture or not.

BUG=614599

Committed: https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17
Cr-Commit-Position: refs/heads/master@{#407638}
==========

[commit-bot: I haz the power, 2016-07-26 00:03:17]

Patchset 6 (id:??) landed as
https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17
Cr-Commit-Position: refs/heads/master@{#407638}