Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 2178213003: Update RequestTrigger to GestureType in permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.h ('k') | chrome/common/safe_browsing/permission_report.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index 808818f5d4e54324ab2f89e6cd22c1a7e3d1a79c..95d323e6a7f68271ce98cac63ca7dfaae12fcc91 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -285,12 +285,12 @@ void SafeBrowsingUIManager::ReportPermissionAction(
content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
- bool user_gesture) {
+ PermissionRequestGestureType gesture_type) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(&SafeBrowsingUIManager::ReportPermissionActionOnIOThread, this,
- origin, permission, action, source_ui, user_gesture));
+ origin, permission, action, source_ui, gesture_type));
}
void SafeBrowsingUIManager::AddObserver(Observer* observer) {
@@ -320,7 +320,7 @@ void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
- bool user_gesture) {
+ PermissionRequestGestureType gesture_type) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// The service may delete the ping manager (i.e. when user disabling service,
@@ -329,7 +329,7 @@ void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
return;
sb_service_->ping_manager()->ReportPermissionAction(
- origin, permission, action, source_ui, user_gesture);
+ origin, permission, action, source_ui, gesture_type);
}
// If the user had opted-in to send ThreatDetails, this gets called
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.h ('k') | chrome/common/safe_browsing/permission_report.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698