Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/safe_browsing/ui_manager.h

Issue 2178213003: Update RequestTrigger to GestureType in permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ping_manager.cc ('k') | chrome/browser/safe_browsing/ui_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/ui_manager.h
diff --git a/chrome/browser/safe_browsing/ui_manager.h b/chrome/browser/safe_browsing/ui_manager.h
index af1e510c9b5a3b1092868df5d3deed7f635dc2d9..c94fc55109417f6c78f896e0ae1b7d071ba4ab06 100644
--- a/chrome/browser/safe_browsing/ui_manager.h
+++ b/chrome/browser/safe_browsing/ui_manager.h
@@ -16,6 +16,7 @@
#include "base/memory/ref_counted.h"
#include "base/observer_list.h"
#include "base/time/time.h"
+#include "chrome/browser/permissions/permission_request.h"
#include "chrome/browser/permissions/permission_uma_util.h"
#include "components/safe_browsing_db/hit_report.h"
#include "components/safe_browsing_db/util.h"
@@ -156,7 +157,7 @@ class SafeBrowsingUIManager
content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
- bool user_gesture);
+ PermissionRequestGestureType gesture_type);
// Add and remove observers. These methods must be invoked on the UI thread.
void AddObserver(Observer* observer);
@@ -179,11 +180,12 @@ class SafeBrowsingUIManager
const std::string& serialized_report);
// Report permission action to SafeBrowsing servers.
- void ReportPermissionActionOnIOThread(const GURL& origin,
- content::PermissionType permission,
- PermissionAction action,
- PermissionSourceUI source_ui,
- bool user_gesture);
+ void ReportPermissionActionOnIOThread(
+ const GURL& origin,
+ content::PermissionType permission,
+ PermissionAction action,
+ PermissionSourceUI source_ui,
+ PermissionRequestGestureType gesture_type);
// Updates the whitelist state. Called on the UI thread.
void AddToWhitelist(const UnsafeResource& resource);
« no previous file with comments | « chrome/browser/safe_browsing/ping_manager.cc ('k') | chrome/browser/safe_browsing/ui_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698