Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/common/safe_browsing/permission_report.proto

Issue 2178213003: Update RequestTrigger to GestureType in permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Protocol buffer for permission reports sent to the Safe Browsing client-side 5 // Protocol buffer for permission reports sent to the Safe Browsing client-side
6 // detection (CSD) frontends. This should stay in sync with the Safe Browsing 6 // detection (CSD) frontends. This should stay in sync with the Safe Browsing
7 // server-side protocol buffer. 7 // server-side protocol buffer.
8 8
9 syntax = "proto2"; 9 syntax = "proto2";
10 10
11 option optimize_for = LITE_RUNTIME; 11 option optimize_for = LITE_RUNTIME;
12 12
13 package safe_browsing; 13 package safe_browsing;
14 14
15 // A single Permission Report sent to Safe Browsing client-side detection 15 // A single Permission Report sent to Safe Browsing client-side detection
16 // frontends. 16 // frontends.
17 message PermissionReport { 17 message PermissionReport {
18 // The origin (scheme/host/port) of the site requesting the permission. 18 // The origin (scheme/host/port) of the site requesting the permission.
19 optional string origin = 1; 19 optional string origin = 1;
20 20
21 // The permission being requested/acted upon. 21 // The permission being requested/acted upon.
22 optional PermissionType permission = 2; 22 optional PermissionType permission = 2;
23 23
24 // The platform. 24 // The platform.
25 optional PlatformType platform_type = 3; 25 optional PlatformType platform_type = 3;
26 26
27 // When the request was initiated. 27 // Whether the action was after a user gesture.
28 repeated RequestTrigger request_trigger = 4; 28 optional GestureType gesture = 4;
29 29
30 // The action the user took. Required. 30 // The action the user took. Required.
31 optional Action action = 5; 31 optional Action action = 5;
32 32
33 // The UI used to complete the action. 33 // The UI used to complete the action.
34 optional SourceUI source_ui = 6; 34 optional SourceUI source_ui = 6;
35 35
36 // The relevant field trials enabled for this report. 36 // The relevant field trials enabled for this report.
37 repeated FieldTrial field_trials = 7; 37 repeated FieldTrial field_trials = 7;
38 38
39 // Platform 39 // Platform
40 enum PlatformType { 40 enum PlatformType {
41 PLATFORM_TYPE_UNSPECIFIED = 0; 41 PLATFORM_TYPE_UNSPECIFIED = 0;
42 DESKTOP_PLATFORM = 1; 42 DESKTOP_PLATFORM = 1;
43 ANDROID_PLATFORM = 2; 43 ANDROID_PLATFORM = 2;
44 } 44 }
45 45
46 // Various request triggers we want to record, e.g. on page load. 46 // Whether the action occurred after a user gesture.
47 enum RequestTrigger { 47 enum GestureType {
48 REQUEST_TRIGGER_UNSPECIFIED = 0; 48 GESTURE_TYPE_UNSPECIFIED = 0;
49 ONLOAD = 1; 49 GESTURE = 1;
50 AFTER_GESTURE = 2; 50 NO_GESTURE = 2;
51 } 51 }
52 52
53 // User Permission Actions. This enum is intentionally different with 53 // User Permission Actions. This enum is intentionally different with
54 // the one in src/chrome/browser/permissions/permission_uma_util.h 54 // the one in src/chrome/browser/permissions/permission_uma_util.h
55 enum Action { 55 enum Action {
56 ACTION_UNSPECIFIED = 0; 56 ACTION_UNSPECIFIED = 0;
57 GRANTED = 1; 57 GRANTED = 1;
58 DENIED = 2; 58 DENIED = 2;
59 DISMISSED = 3; 59 DISMISSED = 3;
60 IGNORED = 4; 60 IGNORED = 4;
(...skipping 30 matching lines...) Expand all
91 message FieldTrial { 91 message FieldTrial {
92 // The name of the field trial, as a 32-bit identifier. Currently, the 92 // The name of the field trial, as a 32-bit identifier. Currently, the
93 // identifier is a hash of the field trial's name. 93 // identifier is a hash of the field trial's name.
94 optional fixed32 name_id = 1; 94 optional fixed32 name_id = 1;
95 95
96 // The user's group within the field trial, as a 32-bit identifier. 96 // The user's group within the field trial, as a 32-bit identifier.
97 // Currently, the identifier is a hash of the group's name. 97 // Currently, the identifier is a hash of the group's name.
98 optional fixed32 group_id = 2; 98 optional fixed32 group_id = 2;
99 } 99 }
100 } 100 }
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698