Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, gavinp+loader_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, falken, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, horo+watch_chromium.org, kinuko+watch, Nate Chapin, Inactive
Visibility:
Public.

Description

Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/) Also reverting dependent patch https://codereview.chromium.org/213543004 Reason for revert: Likely to have caused memory leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 (1) Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (2) Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (3) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 Original issue's description: > Make DOMWrapperWorld::current() return a reference instead of a pointer > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > BUG=341032 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=341032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170357

Patch Set 1 #

Patch Set 2 : Revert 213543004 too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6881 lines, -10990 lines) Patch
M Source/bindings/templates/callback_interface.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/idls/SVGTestInterface.idl View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/idls/TestEventTarget.idl View 1 1 chunk +7 lines, -19 lines 0 comments Download
M Source/bindings/tests/idls/TestImplements.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestImplements2.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestImplements3.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterface.idl View 1 1 chunk +31 lines, -59 lines 0 comments Download
D Source/bindings/tests/idls/TestInterface2.idl View 1 1 chunk +0 lines, -52 lines 0 comments Download
D Source/bindings/tests/idls/TestInterface3.idl View 1 1 chunk +0 lines, -46 lines 0 comments Download
A + Source/bindings/tests/idls/TestInterfaceDoNotCheckConstants.idl View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + Source/bindings/tests/idls/TestInterfacePython.idl View 1 1 chunk +7 lines, -25 lines 0 comments Download
A + Source/bindings/tests/idls/TestInterfacePython2.idl View 1 1 chunk +7 lines, -11 lines 0 comments Download
A + Source/bindings/tests/idls/TestInterfacePython3.idl View 1 1 chunk +6 lines, -7 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 1 chunk +286 lines, -445 lines 0 comments Download
A + Source/bindings/tests/idls/TestObjectPython.idl View 1 12 chunks +11 lines, -18 lines 0 comments Download
M Source/bindings/tests/idls/TestPartialInterface.idl View 1 1 chunk +36 lines, -43 lines 0 comments Download
D Source/bindings/tests/idls/TestPartialInterface2.idl View 1 1 chunk +0 lines, -42 lines 0 comments Download
A + Source/bindings/tests/idls/TestPartialInterfacePython.idl View 1 2 chunks +6 lines, -5 lines 0 comments Download
A + Source/bindings/tests/idls/TestPartialInterfacePython2.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
D Source/bindings/tests/idls/TestSpecialOperations.idl View 1 1 chunk +0 lines, -12 lines 0 comments Download
A + Source/bindings/tests/idls/TestSpecialOperationsAnonymous.idl View 1 1 chunk +9 lines, -7 lines 0 comments Download
A + Source/bindings/tests/idls/TestSpecialOperationsCustom.idl View 1 1 chunk +7 lines, -6 lines 0 comments Download
A + Source/bindings/tests/idls/TestSpecialOperationsIdentifierRaisesException.idl View 1 2 chunks +2 lines, -13 lines 0 comments Download
A Source/bindings/tests/idls/TestSpecialOperationsInt.idl View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + Source/bindings/tests/idls/TestSpecialOperationsOverrideBuiltins.idl View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/TestTypedefs.idl View 1 2 chunks +18 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallbackInterface.cpp View 1 10 chunks +10 lines, -10 lines 0 comments Download
A + Source/bindings/tests/results/V8TestEventTarget.h View 1 2 chunks +36 lines, -30 lines 0 comments Download
A Source/bindings/tests/results/V8TestEventTarget.cpp View 1 1 chunk +335 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 2 chunks +68 lines, -27 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 26 chunks +321 lines, -802 lines 0 comments Download
D Source/bindings/tests/results/V8TestInterface2.h View 1 1 chunk +0 lines, -126 lines 0 comments Download
D Source/bindings/tests/results/V8TestInterface2.cpp View 1 1 chunk +0 lines, -504 lines 0 comments Download
D Source/bindings/tests/results/V8TestInterface3.h View 1 1 chunk +0 lines, -138 lines 0 comments Download
D Source/bindings/tests/results/V8TestInterface3.cpp View 1 1 chunk +0 lines, -183 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h View 1 2 chunks +33 lines, -30 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 1 4 chunks +24 lines, -19 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython.h View 1 3 chunks +21 lines, -21 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython.cpp View 1 50 chunks +236 lines, -405 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython2.h View 1 2 chunks +27 lines, -27 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython2.cpp View 1 6 chunks +53 lines, -32 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython3.h View 1 2 chunks +32 lines, -28 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfacePython3.cpp View 1 5 chunks +19 lines, -19 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 3 chunks +12 lines, -23 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 9 chunks +2689 lines, -5092 lines 0 comments Download
A + Source/bindings/tests/results/V8TestObjectPython.h View 1 3 chunks +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestObjectPython.cpp View 1 298 chunks +1491 lines, -1590 lines 0 comments Download
D Source/bindings/tests/results/V8TestSpecialOperations.h View 1 1 chunk +0 lines, -129 lines 0 comments Download
D Source/bindings/tests/results/V8TestSpecialOperations.cpp View 1 1 chunk +0 lines, -252 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.h View 1 2 chunks +29 lines, -29 lines 0 comments Download
A Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 1 1 chunk +278 lines, -0 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsCustom.h View 1 3 chunks +29 lines, -30 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsCustom.cpp View 1 4 chunks +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.h View 1 2 chunks +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 1 19 chunks +71 lines, -126 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsInt.h View 1 2 chunks +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 1 7 chunks +72 lines, -74 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.h View 1 2 chunks +29 lines, -29 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 1 7 chunks +35 lines, -84 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 5 chunks +229 lines, -58 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/CustomElementWrapper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/DOMDataStore.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/DOMDataStore.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/DOMRequestState.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/MIDIAccessResolver.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptController.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 1 4 chunks +15 lines, -11 lines 0 comments Download
M Source/bindings/v8/ScriptPreprocessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8DOMConfiguration.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8DOMConfiguration.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8ErrorHandler.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8PerContextData.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8PerContextData.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/WorkerScriptController.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/WorkerScriptController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomEventCustom.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8TypedArrayCustom.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/EventListener.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
enne (OOO)
Created Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer
6 years, 9 months ago (2014-03-28 19:23:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/217053007/1
6 years, 9 months ago (2014-03-28 19:23:29 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 19:23:53 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/bindings/tests/results/V8TestEventTarget.h: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 9 months ago (2014-03-28 19:23:53 UTC) #4
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-28 19:39:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/217053007/23
6 years, 9 months ago (2014-03-28 19:39:26 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 19:41:54 UTC) #7
Message was sent while issue was closed.
Change committed as 170357

Powered by Google App Engine
This is Rietveld 408576698