Consolidate IDL test cases (15%: 34 => 29)

Consolidate IDL test cases (15%: 34 => 29)

This consolidates the test cases post-rewrite.

Specifically:
* Remove old Perl TestInterface and TestObject (-2 files)
* Move special operations into TestInterface{,2,3} (-2 files)
(2 TestSpecialOperations*.idl left b/c 5 variants total, if squeezed so overlap)
* Remove TestEventTarget, as covered by TestInterfaceEventTarget (-1 file)
* Rename s/(.*)Python.idl/\1.idl

TBR=haraken
BUG=239771
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170287

[Nils Barth (inactive), 2014-03-28 06:31:13]

Test cleanup!

https://codereview.chromium.org/213543004/diff/10001/Source/bindings/tests/id...
File Source/bindings/tests/idls/TestTypedefs.idl (left):

https://codereview.chromium.org/213543004/diff/10001/Source/bindings/tests/id...
Source/bindings/tests/idls/TestTypedefs.idl:39: typedef DOMException            
  E;
No uses of the 1 exception (DOMException) as a type *in* IDL files
(just defines the interface).

[Nils Barth (inactive), 2014-03-28 06:31:18]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-28 06:31:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/213543004/10001

[commit-bot: I haz the power, 2014-03-28 06:31:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 06:31:53]

Failed to apply patch for Source/bindings/tests/results/V8TestInterface2.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/bindings/tests/results/V8TestInterface2.h
  Copied Source/bindings/tests/results/V8TestInterfacePython2.h ->
Source/bindings/tests/results/V8TestInterface2.h
  patching file Source/bindings/tests/results/V8TestInterface2.h
  Hunk #2 FAILED at 15.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestInterface2.h.rej

Patch:   NR 
Source/bindings/tests/results/V8TestInterfacePython2.h->Source/bindings/tests/results/V8TestInterface2.h
Index: Source/bindings/tests/results/V8TestInterface2.h
diff --git a/Source/bindings/tests/results/V8TestInterfacePython2.h
b/Source/bindings/tests/results/V8TestInterface2.h
similarity index 67%
rename from Source/bindings/tests/results/V8TestInterfacePython2.h
rename to Source/bindings/tests/results/V8TestInterface2.h
index
25eab9b19480c9f85430335842be6bc382693e2c..4c51b52f7e2a1044d3033b0d690655d93622b26e
100644
--- a/Source/bindings/tests/results/V8TestInterfacePython2.h
+++ b/Source/bindings/tests/results/V8TestInterface2.h
@@ -4,10 +4,10 @@
 
 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
 
-#ifndef V8TestInterfacePython2_h
-#define V8TestInterfacePython2_h
+#ifndef V8TestInterface2_h
+#define V8TestInterface2_h
 
-#include "bindings/tests/idls/TestInterfacePython2.h"
+#include "bindings/tests/idls/TestInterface2.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8DOMWrapper.h"
 #include "bindings/v8/WrapperTypeInfo.h"
@@ -15,112 +15,112 @@
 
 namespace WebCore {
 
-class V8TestInterfacePython2 {
+class V8TestInterface2 {
 public:
     static bool hasInstance(v8::Handle<v8::Value>, v8::Isolate*);
     static v8::Handle<v8::Object>
findInstanceInPrototypeChain(v8::Handle<v8::Value>, v8::Isolate*);
     static v8::Handle<v8::FunctionTemplate> domTemplate(v8::Isolate*);
-    static TestInterfacePython2* toNative(v8::Handle<v8::Object> object)
+    static TestInterface2* toNative(v8::Handle<v8::Object> object)
     {
         return
fromInternalPointer(object->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex));
     }
-    static TestInterfacePython2* toNativeWithTypeCheck(v8::Isolate*,
v8::Handle<v8::Value>);
+    static TestInterface2* toNativeWithTypeCheck(v8::Isolate*,
v8::Handle<v8::Value>);
     static const WrapperTypeInfo wrapperTypeInfo;
     static void derefObject(void*);
     static void visitDOMWrapper(void*, const v8::Persistent<v8::Object>&,
v8::Isolate*);
     static void constructorCallback(const
v8::FunctionCallbackInfo<v8::Value>&);
     static const int internalFieldCount = v8DefaultWrapperInternalFieldCount +
0;
-    static inline void* toInternalPointer(TestInterfacePython2* impl)
+    static inline void* toInternalPointer(TestInterface2* impl)
     {
         return impl;
     }
 
-    static inline TestInterfacePython2* fromInternalPointer(void* object)
+    static inline TestInterface2* fromInternalPointer(void* object)
     {
-        return static_cast<TestInterfacePython2*>(object);
+        return static_cast<TestInterface2*>(object);
     }
-    static void installPerContextEnabledProperties(v8::Handle<v8::Object>,
TestInterfacePython2*, v8::Isolate*) { }
+    static void installPerContextEnabledProperties(v8::Handle<v8::Object>,
TestInterface2*, v8::Isolate*) { }
     static void installPerContextEnabledMethods(v8::Handle<v8::Object>,
v8::Isolate*) { }
 
 private:
-    friend v8::Handle<v8::Object> wrap(TestInterfacePython2*,
v8::Handle<v8::Object> creationContext, v8::Isolate*);
-    static v8::Handle<v8::Object>
createWrapper(PassRefPtr<TestInterfacePython2>, v8::Handle<v8::Object>
creationContext, v8::Isolate*);
+    friend v8::Handle<v8::Object> wrap(TestInterface2*, v8::Handle<v8::Object>
creationContext, v8::Isolate*);
+    static v8::Handle<v8::Object> createWrapper(PassRefPtr<TestInterface2>,
v8::Handle<v8::Object> creationContext, v8::Isolate*);
 };
 
-v8::Handle<v8::Object> wrap(TestInterfacePython2* impl, v8::Handle<v8::Object>
creationContext, v8::Isolate*);
+v8::Handle<v8::Object> wrap(TestInterface2* impl, v8::Handle<v8::Object>
creationContext, v8::Isolate*);
 
-inline v8::Handle<v8::Value> toV8(TestInterfacePython2* impl,
v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+inline v8::Handle<v8::Value> toV8(TestInterface2* impl, v8::Handle<v8::Object>
creationContext, v8::Isolate* isolate)
 {
     if (UNLIKELY(!impl))
         return v8::Null(isolate);
-    v8::Handle<v8::Value> wrapper =
DOMDataStore::getWrapper<V8TestInterfacePython2>(impl, isolate);
+    v8::Handle<v8::Value> wrapper =
DOMDataStore::getWrapper<V8TestInterface2>(impl, isolate);
     if (!wrapper.IsEmpty())
         return wrapper;
     return wrap(impl, creationContext, isolate);
 }
 
 template<typename CallbackInfo>
-inline void v8SetReturnValue(const CallbackInfo& callbackInfo,
TestInterfacePython2* impl)
+inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestInterface2*
impl)
 {
     if (UNLIKELY(!impl)) {
         v8SetReturnValueNull(callbackInfo);
         return;
     }
-    if
(DOMDataStore::setReturnValueFromWrapper<V8TestInterfacePython2>(callbackInfo.GetReturnValue(),
impl))
+    if
(DOMDataStore::setReturnValueFromWrapper<V8TestInterface2>(callbackInfo.GetReturnValue(),
impl))
         return;
     v8::Handle<v8::Object> wrapper = wrap(impl, callbackInfo.Holder(),
callbackInfo.GetIsolate());
     v8SetReturnValue(callbackInfo, wrapper);
 }
 
 template<typename CallbackInfo>
-inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo,
TestInterfacePython2* impl)
+inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo,
TestInterface2* impl)
 {
     ASSERT(DOMWrapperWorld::current(callbackInfo.GetIsolate())->isMainWorld());
     if (UNLIKELY(!impl)) {
         v8SetReturnValueNull(callbackInfo);
         return;
     }
-    if
(DOMDataStore::setReturnValueFromWrapperForMainWorld<V8TestInterfacePython2>(callbackInfo.GetReturnValue(),
impl))
+    if
(DOMDataStore::setReturnValueFromWrapperForMainWorld<V8TestInterface2>(callbackInfo.GetReturnValue(),
impl))
         return;
     v8::Handle<v8::Value> wrapper = wrap(impl, callbackInfo.Holder(),
callbackInfo.GetIsolate());
     v8SetReturnValue(callbackInfo, wrapper);
 }
 
 template<class CallbackInfo, class Wrappable>
-inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo,
TestInterfacePython2* impl, Wrappable* wrappable)
+inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo,
TestInterface2* impl, Wrappable* wrappable)
 {
     if (UNLIKELY(!impl)) {
         v8SetReturnValueNull(callbackInfo);
         return;
     }
-    if
(DOMDataStore::setReturnValueFromWrapperFast<V8TestInterfacePython2>(callbackInfo.GetReturnValue(),
impl, callbackInfo.Holder(), wrappable))
+    if
(DOMDataStore::setReturnValueFromWrapperFast<V8TestInterface2>(callbackInfo.GetReturnValue(),
impl, callbackInfo.Holder(), wrappable))
         return;
     v8::Handle<v8::Object> wrapper = wrap(impl, callbackInfo.Holder(),
callbackInfo.GetIsolate());
     v8SetReturnValue(callbackInfo, wrapper);
 }
 
-inline v8::Handle<v8::Value> toV8(PassRefPtr<TestInterfacePython2> impl,
v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+inline v8::Handle<v8::Value> toV8(PassRefPtr<TestInterface2> impl,
v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     return toV8(impl.get(), creationContext, isolate);
 }
 
 template<class CallbackInfo>
-inline void v8SetReturnValue(const CallbackInfo& callbackInfo,
PassRefPtr<TestInterfacePython2> impl)
+inline void v8SetReturnValue(const CallbackInfo& callbackInfo,
PassRefPtr<TestInterface2> impl)
 {
     v8SetReturnValue(callbackInfo, impl.get());
 }
 
 template<class CallbackInfo>
-inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo,
PassRefPtr<TestInterfacePython2> impl)
+inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo,
PassRefPtr<TestInterface2> impl)
 {
     v8SetReturnValueForMainWorld(callbackInfo, impl.get());
 }
 
 template<class CallbackInfo, class Wrappable>
-inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo,
PassRefPtr<TestInterfacePython2> impl, Wrappable* wrappable)
+inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo,
PassRefPtr<TestInterface2> impl, Wrappable* wrappable)
 {
     v8SetReturnValueFast(callbackInfo, impl.get(), wrappable);
 }
 
 }
-#endif // V8TestInterfacePython2_h
+#endif // V8TestInterface2_h

[haraken, 2014-03-28 06:33:55]

rubberstamp LGTM.

Can we remove more, or is this the minimum state?

[Nils Barth (inactive), 2014-03-28 06:42:03]

On 2014/03/28 06:33:55, haraken wrote:
> rubberstamp LGTM.
> 
> Can we remove more, or is this the minimum state?

This is minimum, and it's already squeezing pretty tight (there are overlapping
features,
but they're orthogonal so we can squeeze them in).
(In any event, TestObject.idl is half the (non-license header) lines of tests.)

The reason for needing this number of test cases is:
* dependencies (implements and partial interfaces)
* interface extended attributes
* special operations
* constructors (inc. custom constructors and named constructors)
* special inheritance (Document, EventTarget, Node)

Each variant of these needs a new interface file, because we can't test multiple
variants in one test.

[Nils Barth (inactive), 2014-03-28 06:44:50]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-28 06:44:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/213543004/30001

[commit-bot: I haz the power, 2014-03-28 06:45:57]

Change committed as 170287

[enne (OOO), 2014-03-28 19:39:44]

Reverting this in https://codereview.chromium.org/217053007/, sorry.

[Nils Barth (inactive), 2014-03-31 01:08:46]

On 2014/03/28 19:39:44, enne wrote:
> Reverting this in https://codereview.chromium.org/217053007/, sorry.

n/p; un-reverted in:
https://codereview.chromium.org/218813002