Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revert 213543004 too Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/tests/CustomEventTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions 4 # modification, are permitted provided that the following conditions
5 # are met: 5 # are met:
6 # 1. Redistributions of source code must retain the above copyright 6 # 1. Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # 2. Redistributions in binary form must reproduce the above copyright 8 # 2. Redistributions in binary form must reproduce the above copyright
9 # notice, this list of conditions and the following disclaimer in the 9 # notice, this list of conditions and the following disclaimer in the
10 # documentation and/or other materials provided with the distribution. 10 # documentation and/or other materials provided with the distribution.
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 To update the reference files, execute: 47 To update the reference files, execute:
48 run-bindings-tests --reset-results 48 run-bindings-tests --reset-results
49 49
50 If the failures are not due to your changes, test results may be out of sync; 50 If the failures are not due to your changes, test results may be out of sync;
51 please rebaseline them in a separate CL, after checking that tests fail in ToT. 51 please rebaseline them in a separate CL, after checking that tests fail in ToT.
52 In CL, please set: 52 In CL, please set:
53 NOTRY=true 53 NOTRY=true
54 TBR=(someone in Source/bindings/OWNERS or WATCHLISTS:bindings) 54 TBR=(someone in Source/bindings/OWNERS or WATCHLISTS:bindings)
55 """ 55 """
56 56
57 DEPENDENCY_IDL_FILES = frozenset([ 57 DEPENDENCY_IDL_FILES = set([
58 'SupportTestPartialInterface.idl',
58 'TestImplements.idl', 59 'TestImplements.idl',
59 'TestImplements2.idl', 60 'TestImplements2.idl',
60 'TestImplements3.idl', 61 'TestImplements3.idl',
61 'TestPartialInterface.idl', 62 'TestPartialInterface.idl',
62 'TestPartialInterface2.idl', 63 'TestPartialInterfacePython.idl',
64 'TestPartialInterfacePython2.idl',
63 ]) 65 ])
64 66
65 67
66 EXTENDED_ATTRIBUTES_FILE = os.path.join(source_path, 68 EXTENDED_ATTRIBUTES_FILE = os.path.join(source_path,
67 'bindings/IDLExtendedAttributes.txt') 69 'bindings/IDLExtendedAttributes.txt')
68 70
69 test_input_directory = os.path.join(source_path, 'bindings', 'tests', 'idls') 71 test_input_directory = os.path.join(source_path, 'bindings', 'tests', 'idls')
70 reference_directory = os.path.join(source_path, 'bindings', 'tests', 'results') 72 reference_directory = os.path.join(source_path, 'bindings', 'tests', 'results')
71 73
72 74
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 206
205 207
206 def run_bindings_tests(reset_results, verbose): 208 def run_bindings_tests(reset_results, verbose):
207 # Generate output into the reference directory if resetting results, or 209 # Generate output into the reference directory if resetting results, or
208 # a temp directory if not. 210 # a temp directory if not.
209 if reset_results: 211 if reset_results:
210 print 'Resetting results' 212 print 'Resetting results'
211 return bindings_tests(reference_directory, verbose) 213 return bindings_tests(reference_directory, verbose)
212 with ScopedTempDir() as temp_dir: 214 with ScopedTempDir() as temp_dir:
213 return bindings_tests(temp_dir, verbose) 215 return bindings_tests(temp_dir, verbose)
OLDNEW
« no previous file with comments | « Source/web/tests/CustomEventTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698