Source/bindings/tests/results/V8TestInterfaceDocument.cpp - Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceDocument.cpp

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert 213543004 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceDocument.h ('k') | Source/bindings/tests/results/V8TestInterfaceEmpty.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceDocument.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceDocument.cpp b/Source/bindings/tests/results/V8TestInterfaceDocument.cpp

index 532f0f22b2fd293f00faf17ec2e176ec35cc7c99..1ae803dcfb9059f340355cf5d4c9d46a886d9f7a 100644

--- a/Source/bindings/tests/results/V8TestInterfaceDocument.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceDocument.cpp

@@ -104,8 +104,8 @@ v8::Handle<v8::Object> wrap(TestInterfaceDocument* impl, v8::Handle<v8::Object>

v8::Handle<v8::Object> wrapper = V8TestInterfaceDocument::createWrapper(impl, creationContext, isolate);

if (wrapper.IsEmpty())

return wrapper;

- DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);

- if (world.isMainWorld()) {

+ DOMWrapperWorld* world = DOMWrapperWorld::current(isolate);

+ if (world->isMainWorld()) {

if (LocalFrame* frame = impl->frame())

frame->script().windowShell(world)->updateDocumentWrapper(wrapper);

}

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceDocument.h ('k') | Source/bindings/tests/results/V8TestInterfaceEmpty.h » ('j') | no next file with comments »