Make DOMWrapperWorld::current() return a reference instead of a pointer

Make DOMWrapperWorld::current() return a reference instead of a pointer

Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer.

BUG=341032
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261

[dcarney, 2014-03-24 07:24:24]

lgtm

[haraken, 2014-03-24 07:25:16]

On 2014/03/24 07:24:24, dcarney wrote:
> lgtm

Thanks, I'll take care of a couple of failures on the bots.

[haraken, 2014-03-26 07:38:31]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-26 07:38:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/209713003/20001

[commit-bot: I haz the power, 2014-03-26 07:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 07:48:57]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[haraken, 2014-03-26 09:25:37]

jochen@: would you take a look at web/ ?

[haraken, 2014-03-27 01:34:50]

jochen: ping?

[haraken, 2014-03-28 01:34:37]

abarth: would you rubberstamp web/ ?

[abarth-chromium, 2014-03-28 03:58:33]

Source/web LGTM

[haraken, 2014-03-28 03:58:51]

The CQ bit was checked by haraken@chromium.org

[haraken, 2014-03-28 03:58:55]

On 2014/03/28 03:58:33, abarth wrote:
> Source/web LGTM

Thanks!

[commit-bot: I haz the power, 2014-03-28 03:59:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/209713003/20001

[commit-bot: I haz the power, 2014-03-28 04:14:03]

Change committed as 170261

[enne (OOO), 2014-03-28 19:23:24]

A revert of this CL has been created in
https://codereview.chromium.org/217053007/ by enne@chromium.org.

The reason for reverting is: Likely to have caused memory leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Te...

(1)
Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long)
/usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9bdfd8a in
WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>,
WTF::PassRefPtr<WebCore::DOMWrapperWorld>)
third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
    #2 0x9bdfa06 in
WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>,
WTF::PassRefPtr<WebCore::DOMWrapperWorld>)
third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
    #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>,
WTF::PassRefPtr<WebCore::DOMWrapperWorld>)
third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
    #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext()
third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132

(2)
Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long)
/usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9b2ee18 in operator new
third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
    #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int)
third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
    #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext()
third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
 
(3)
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x4b46c1 in __interceptor_malloc
/usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
    #1 0x62caf0a in partitionAllocGenericFlags
third_party/WebKit/Source/wtf/PartitionAlloc.h:533
    #2 0x62caf0a in partitionAllocGeneric
third_party/WebKit/Source/wtf/PartitionAlloc.h:549
    #3 0x62caf0a in WTF::fastMalloc(unsigned long)
third_party/WebKit/Source/wtf/FastMalloc.cpp:125
    #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175
    #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int)
third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53.

[haraken, 2014-03-29 01:48:19]

On 2014/03/28 19:23:24, enne wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/217053007/ by mailto:enne@chromium.org.
> 
> The reason for reverting is: Likely to have caused memory leaks:
>
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Te...
> 
> (1)
> Direct leak of 32 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long)
>
/usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9bdfd8a in
> WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>,
> WTF::PassRefPtr<WebCore::DOMWrapperWorld>)
> third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
>     #2 0x9bdfa06 in
> WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>,
> WTF::PassRefPtr<WebCore::DOMWrapperWorld>)
> third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
>     #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>,
> WTF::PassRefPtr<WebCore::DOMWrapperWorld>)
> third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
>     #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext()
> third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
> 
> (2)
> Indirect leak of 40 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long)
>
/usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9b2ee18 in operator new
> third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
>     #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int)
> third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
>     #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext()
> third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
>  
> (3)
> Indirect leak of 24 byte(s) in 1 object(s) allocated from:
>     #0 0x4b46c1 in __interceptor_malloc
>
/usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
>     #1 0x62caf0a in partitionAllocGenericFlags
> third_party/WebKit/Source/wtf/PartitionAlloc.h:533
>     #2 0x62caf0a in partitionAllocGeneric
> third_party/WebKit/Source/wtf/PartitionAlloc.h:549
>     #3 0x62caf0a in WTF::fastMalloc(unsigned long)
> third_party/WebKit/Source/wtf/FastMalloc.cpp:125
>     #4 0x9b2ed61 in operator new
third_party/WebKit/Source/wtf/RefCounted.h:175
>     #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int)
> third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53.

Thanks for gardening!

Actually these leaks are intentional ones. This CL changed method signatures, so
the existing leaks are reported as new leaks. Let me update leak suppression
files and reland the CL.