Source/bindings/v8/CustomElementWrapper.cpp - Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementWrapper.cpp

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert 213543004 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/CustomElementWrapper.cpp

diff --git a/Source/bindings/v8/CustomElementWrapper.cpp b/Source/bindings/v8/CustomElementWrapper.cpp

index 8e44d2a99f77a1a82b5cd46fea8e104454e8d0d0..f4fafbb5f23fb8955bbb0517e2b70b33cb78ca8b 100644

--- a/Source/bindings/v8/CustomElementWrapper.cpp

+++ b/Source/bindings/v8/CustomElementWrapper.cpp

@@ -95,7 +95,7 @@ v8::Handle<v8::Object> CustomElementWrapper<ElementType, WrapperType>::wrap(Pass

// to never pass an empty creation context.

v8::Handle<v8::Context> context = creationContext.IsEmpty() ? isolate->GetCurrentContext() : creationContext->CreationContext();

- if (!element->isUpgradedCustomElement() || DOMWrapperWorld::world(context).isIsolatedWorld())

+ if (!element->isUpgradedCustomElement() || DOMWrapperWorld::world(context)->isIsolatedWorld())

return createUpgradeCandidateWrapper(element.get(), creationContext, isolate, createSpecificWrapper);

V8PerContextData* perContextData = V8PerContextData::from(context);

« no previous file with comments | « Source/bindings/v8/CustomElementConstructorBuilder.cpp ('k') | Source/bindings/v8/DOMDataStore.h » ('j') | no next file with comments »