Source/bindings/templates/interface.h - Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface.h

Issue 217053007: Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert 213543004 too Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/interface.h

diff --git a/Source/bindings/templates/interface.h b/Source/bindings/templates/interface.h

index 71c62a861c653c33dff4901697f5963c3c5c6997..3a8e11fd5b5466627f9b74d65787330c8f311829 100644

--- a/Source/bindings/templates/interface.h

+++ b/Source/bindings/templates/interface.h

@@ -229,7 +229,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}* im

template<typename CallbackInfo>

inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, {{cpp_class}}* impl)

{

- ASSERT(DOMWrapperWorld::current(callbackInfo.GetIsolate()).isMainWorld());

+ ASSERT(DOMWrapperWorld::current(callbackInfo.GetIsolate())->isMainWorld());

if (UNLIKELY(!impl)) {

v8SetReturnValueNull(callbackInfo);

return;

« no previous file with comments | « Source/bindings/templates/callback_interface.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »