[DevTools] Pass error object when reporting exceptions.

[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162, 632405
Committed: https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645
Cr-Commit-Position: refs/heads/master@{#408863}

[dgozman, 2016-07-22 04:36:40]

Description was changed from

==========
[DevTools] Pass error object wehn reporting exceptions.

BUG=none
==========

to

==========
[DevTools] Pass error object when reporting exceptions.

BUG=none
==========

[dgozman, 2016-07-27 22:54:09]

Description was changed from

==========
[DevTools] Pass error object when reporting exceptions.

BUG=none
==========

to

==========
[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the
error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162
==========

[dgozman, 2016-07-27 22:55:29]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, pfeldman@chromium.org

[dgozman, 2016-07-27 22:55:30]

Could you please take a look?

[dgozman, 2016-07-27 22:55:36]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 22:56:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-07-27 22:56:48]

The CQ bit was unchecked by dgozman@chromium.org

[kozy, 2016-07-28 17:18:51]

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt
(right):

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt:5:
0)  (:1)
Could you create issue for this and mark this test as failed in
TestExpectations?

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp (right):

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp:166:
debugger()->exceptionThrown(scriptState->context(), defaultMessage, exception,
event->messageForConsole(), location->url(), location->lineNumber(),
location->columnNumber(), location->cloneStackTrace(), location->scriptId());
Could we extract this code from here and WorkerThreadDebugger and put it to
ThreadDebugger?

[kozy, 2016-07-28 17:24:01]

lgtm

[dgozman, 2016-07-28 17:34:47]

Description was changed from

==========
[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the
error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162
==========

to

==========
[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the
error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162,632405
==========

[dgozman, 2016-07-28 17:40:56]

Pavel, PTAL.

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt
(right):

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt:5:
0)  (:1)
On 2016/07/28 17:18:51, kozyatinskiy wrote:
> Could you create issue for this and mark this test as failed in
> TestExpectations?

Done.

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp (right):

https://codereview.chromium.org/2170263002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp:166:
debugger()->exceptionThrown(scriptState->context(), defaultMessage, exception,
event->messageForConsole(), location->url(), location->lineNumber(),
location->columnNumber(), location->cloneStackTrace(), location->scriptId());
On 2016/07/28 17:18:51, kozyatinskiy wrote:
> Could we extract this code from here and WorkerThreadDebugger and put it to
> ThreadDebugger?

Acknowledged.

[dgozman, 2016-07-28 20:17:03]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 20:17:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 20:20:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 20:20:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[pfeldman, 2016-07-28 20:30:06]

lgtm

[dgozman, 2016-07-29 01:22:18]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-29 01:22:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2170263002/#ps120001
(title: "rebased")

[commit-bot: I haz the power, 2016-07-29 01:22:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 01:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 01:46:42]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-07-29 17:06:03]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-29 17:06:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2170263002/#ps140001
(title: "test fix, rebase")

[commit-bot: I haz the power, 2016-07-29 17:06:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 18:02:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 18:02:31]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-07-29 23:50:15]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-29 23:50:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2170263002/#ps160001
(title: "test fix, rebase")

[commit-bot: I haz the power, 2016-07-29 23:50:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 01:11:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-07-30 02:02:23]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-30 02:02:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2170263002/#ps180001
(title: "worklets!")

[commit-bot: I haz the power, 2016-07-30 02:02:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 05:25:27]

Description was changed from

==========
[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the
error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162,632405
==========

to

==========
[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the
error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162,632405
==========

[commit-bot: I haz the power, 2016-07-30 05:25:29]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-07-30 05:27:26]

Description was changed from

==========
[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the
error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162,632405
==========

to

==========
[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the
error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162,632405

Committed: https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645
Cr-Commit-Position: refs/heads/master@{#408863}
==========

[commit-bot: I haz the power, 2016-07-30 05:27:28]

Patchset 10 (id:??) landed as
https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645
Cr-Commit-Position: refs/heads/master@{#408863}