third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp - Issue 2170263002: [DevTools] Pass error object when reporting exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: worklets! Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.h ('k') | third_party/WebKit/Source/core/workers/WorkerGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp

index 54c44cda69b28f9b3b39a6e878775ff1be10021d..31cdeb64b6ff4fc8954da34fe852b41fbdb6f7c2 100644

--- a/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp

@@ -85,11 +85,11 @@ SharedWorkerThread* SharedWorkerGlobalScope::thread()

return static_cast<SharedWorkerThread*>(Base::thread());

}

-void SharedWorkerGlobalScope::exceptionThrown(const String& errorMessage, std::unique_ptr<SourceLocation> location)

+void SharedWorkerGlobalScope::exceptionThrown(ErrorEvent* event)

{

- WorkerGlobalScope::exceptionThrown(errorMessage, location->clone());

+ WorkerGlobalScope::exceptionThrown(event);

if (WorkerThreadDebugger* debugger = WorkerThreadDebugger::from(thread()->isolate()))

- debugger->exceptionThrown(errorMessage, std::move(location));

+ debugger->exceptionThrown(event);

}

DEFINE_TRACE(SharedWorkerGlobalScope)