chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js - Issue 2170263002: [DevTools] Pass error object when reporting exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: worklets! Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/uncaught_exception_logging/extension_page.js ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js

diff --git a/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js b/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js

index 7fd7faef628fbe62a327d338c7eae7f92a19c746..c0c65505e522aef830ab6b16686905af28799053 100644

--- a/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js

+++ b/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js

@@ -6,7 +6,7 @@ function createTestFunction(expected_message) {

return function(tab) {

function onDebuggerEvent(debuggee, method, params) {

if (debuggee.tabId == tab.id && method == 'Runtime.exceptionThrown') {

- if (params.details.text.indexOf(expected_message) > -1) {

+ if (params.exception.value.indexOf(expected_message) > -1) {

chrome.debugger.onEvent.removeListener(onDebuggerEvent);

chrome.test.succeed();

}