third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp - Issue 2170263002: [DevTools] Pass error object when reporting exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: worklets! Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

index ca55fd1d002ff6fdde7e9befbe6af953e2474e64..9c97cd4cb4e8a4f32595eb5cbb3b7ca02e50ef70 100644

--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

@@ -107,7 +107,7 @@ public:

if (m_shouldLogToConsole && m_promiseRejectionId) {

V8PerIsolateData* data = V8PerIsolateData::from(m_scriptState->isolate());

if (data->threadDebugger())

- data->threadDebugger()->debugger()->promiseRejectionRevoked(m_scriptState->context(), m_promiseRejectionId);

+ data->threadDebugger()->promiseRejectionRevoked(m_scriptState->context(), m_promiseRejectionId);

}