third_party/WebKit/Source/core/dom/ExecutionContext.h - Issue 2170263002: [DevTools] Pass error object when reporting exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.h

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: worklets! Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/ExecutionContext.h

diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.h b/third_party/WebKit/Source/core/dom/ExecutionContext.h

index b558c61282e2082b8432e3b060d84f0e5a064283..bd6b16df3a909cc47e6b4d537d1bcf426bc88b12 100644

--- a/third_party/WebKit/Source/core/dom/ExecutionContext.h

+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.h

@@ -106,7 +106,7 @@ public:

void reportException(ErrorEvent*, AccessControlStatus);

virtual void addConsoleMessage(ConsoleMessage*) = 0;

- virtual void exceptionThrown(const String& errorMessage, std::unique_ptr<SourceLocation>) = 0;

+ virtual void exceptionThrown(ErrorEvent*) = 0;

PublicURLManager& publicURLManager();

@@ -170,8 +170,7 @@ private:

unsigned m_circularSequentialID;

bool m_inDispatchErrorEvent;

- class PendingException;

- std::unique_ptr<Vector<std::unique_ptr<PendingException>>> m_pendingExceptions;

+ HeapVector<Member<ErrorEvent>> m_pendingExceptions;

bool m_activeDOMObjectsAreSuspended;

bool m_activeDOMObjectsAreStopped;

« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »