Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: worklets! Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
index 89b138daceb29180086c7e12f1a826874de78bfa..a7454d9c442f79547d144bdb5fc9eababf83550d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
@@ -97,6 +97,21 @@ void V8ErrorHandler::storeExceptionOnErrorEventWrapper(ScriptState* scriptState,
privateError.set(scriptState->context(), wrappedEvent.As<v8::Object>(), data);
}
+// static
+v8::Local<v8::Value> V8ErrorHandler::loadExceptionFromErrorEventWrapper(ScriptState* scriptState, ErrorEvent* event, v8::Local<v8::Object> creationContext)
+{
+ v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, scriptState->isolate());
+ if (wrappedEvent.IsEmpty() || !wrappedEvent->IsObject())
+ return v8::Local<v8::Value>();
+
+ DCHECK(wrappedEvent->IsObject());
+ auto privateError = V8PrivateProperty::getErrorEventError(scriptState->isolate());
+ v8::Local<v8::Value> error = privateError.getOrUndefined(scriptState->context(), wrappedEvent.As<v8::Object>());
+ if (error->IsUndefined())
+ return v8::Local<v8::Value>();
+ return error;
+}
+
bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue)
{
return returnValue->IsBoolean() && returnValue.As<v8::Boolean>()->Value();
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h ('k') | third_party/WebKit/Source/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698