Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

Issue 2170263002: [DevTools] Pass error object when reporting exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: worklets! Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
index 4c3dfdec50564cc3e9ded9f24dd15e51c062865a..7339a9ff087ceb70c53e89ca2aade0b9cd98da9c 100644
--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
@@ -76,7 +76,7 @@ public:
KURL completeURL(const String&) const;
void dispose() final;
- void exceptionUnhandled(const String& errorMessage, std::unique_ptr<SourceLocation>);
+ void exceptionUnhandled(int exceptionId);
void registerEventListener(V8AbstractEventListener*);
void deregisterEventListener(V8AbstractEventListener*);
@@ -143,7 +143,7 @@ protected:
void setV8CacheOptions(V8CacheOptions v8CacheOptions) { m_v8CacheOptions = v8CacheOptions; }
// ExecutionContext
- void exceptionThrown(const String& errorMessage, std::unique_ptr<SourceLocation>) override;
+ void exceptionThrown(ErrorEvent*) override;
void removeURLFromMemoryCache(const KURL&) final;
private:
@@ -185,6 +185,9 @@ private:
Member<ConsoleMessageStorage> m_consoleMessageStorage;
HeapListHashSet<Member<V8AbstractEventListener>> m_eventListeners;
+
+ HeapHashMap<int, Member<ErrorEvent>> m_pendingErrorEvents;
+ int m_lastPendingErrorEventId;
};
DEFINE_TYPE_CASTS(WorkerGlobalScope, ExecutionContext, context, context->isWorkerGlobalScope(), context.isWorkerGlobalScope());

Powered by Google App Engine
This is Rietveld 408576698