DevTools: make all timeline trace events use 0-based line numbers

DevTools: make all timeline trace events use 0-based line numbers

Committed: https://crrev.com/ae0dd7edc2e79e2e4a8cd01f68b343c1946642f0
Cr-Commit-Position: refs/heads/master@{#407021}

[alph, 2016-07-21 22:23:29]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, kozyatinskiy@chromium.org

[alph, 2016-07-21 22:23:37]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 22:24:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2016-07-21 23:04:17]

lgtm

https://codereview.chromium.org/2169153002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2169153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:910:
eventData["lineNumber"] = eventData["scriptLine"];
nit: // Fall-through intended.

https://codereview.chromium.org/2169153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:918:
this._currentScriptEvent = event;
do we want this for CompileScript as well?

[alph, 2016-07-21 23:35:23]

https://codereview.chromium.org/2169153002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
(right):

https://codereview.chromium.org/2169153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:910:
eventData["lineNumber"] = eventData["scriptLine"];
On 2016/07/21 23:04:17, caseq wrote:
> nit: // Fall-through intended.

Done.

https://codereview.chromium.org/2169153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js:918:
this._currentScriptEvent = event;
On 2016/07/21 23:04:17, caseq wrote:
> do we want this for CompileScript as well?

It's usually a nested event. So this code never executed for CompileScript.

[alph, 2016-07-21 23:35:55]

The CQ bit was checked by alph@chromium.org

[alph, 2016-07-21 23:35:56]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2169153002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-07-21 23:36:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 00:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:54:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alph, 2016-07-22 01:06:31]

The CQ bit was checked by alph@chromium.org

[alph, 2016-07-22 01:06:31]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2169153002/#ps40001
(title: "update expectation")

[commit-bot: I haz the power, 2016-07-22 01:06:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:26:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 03:29:34]

Description was changed from

==========
DevTools: make all timeline trace events use 0-based line numbers
==========

to

==========
DevTools: make all timeline trace events use 0-based line numbers

Committed: https://crrev.com/ae0dd7edc2e79e2e4a8cd01f68b343c1946642f0
Cr-Commit-Position: refs/heads/master@{#407021}
==========

[commit-bot: I haz the power, 2016-07-22 03:29:35]

Patchset 3 (id:??) landed as
https://crrev.com/ae0dd7edc2e79e2e4a8cd01f68b343c1946642f0
Cr-Commit-Position: refs/heads/master@{#407021}