third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js - Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expectation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

index f39b76562faa8a58f182c738c0d38e32ff7315bd..5df5b56ada75dc47b7a091e02da4ca97e2eaa0c5 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

@@ -64,7 +64,7 @@ InspectorTest.formatters.formatAsInvalidationCause = function(cause)

return "<undefined>";

var stackTrace;

if (cause.stackTrace && cause.stackTrace.length)

- stackTrace = InspectorTest.formatters.formatAsURL(cause.stackTrace[0].url) + ":" + cause.stackTrace[0].lineNumber;

+ stackTrace = InspectorTest.formatters.formatAsURL(cause.stackTrace[0].url) + ":" + (cause.stackTrace[0].lineNumber + 1);

return "{reason: " + cause.reason + ", stackTrace: " + stackTrace + "}";

}

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id-expected.txt » ('j') | no next file with comments »