Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update expectation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
index 8493864746ade9ba25afc65bb0d26ac81ad4059b..26ed0e3eaab8a60e2e4116b65e34f6a588ba5c1d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
@@ -5,27 +5,24 @@
/**
* @constructor
* @extends {WebInspector.ProfileNode}
- * @param {!ProfilerAgent.CPUProfileNode} sourceNode
+ * @param {!ProfilerAgent.CPUProfileNode} node
* @param {number} sampleTime
*/
-WebInspector.CPUProfileNode = function(sourceNode, sampleTime)
+WebInspector.CPUProfileNode = function(node, sampleTime)
{
- if (sourceNode.callFrame) {
- WebInspector.ProfileNode.call(this, sourceNode.callFrame);
- } else {
- // Backward compatibility for old CPUProfileNode format.
- var frame = /** @type {!RuntimeAgent.CallFrame} */(sourceNode);
- WebInspector.ProfileNode.call(this, {
- functionName: frame.functionName,
- scriptId: frame.scriptId, url: frame.url,
- lineNumber: frame.lineNumber - 1,
- columnNumber: frame.columnNumber - 1
- });
- }
- this.id = sourceNode.id;
- this.self = sourceNode.hitCount * sampleTime;
- this.positionTicks = sourceNode.positionTicks;
- this.deoptReason = sourceNode.deoptReason;
+ var callFrame = node.callFrame || /** @type {!RuntimeAgent.CallFrame} */ ({
+ // Backward compatibility for old SamplingHeapProfileNode format.
+ functionName: node["functionName"],
+ scriptId: node["scriptId"],
+ url: node["url"],
+ lineNumber: node["lineNumber"] - 1,
+ columnNumber: node["columnNumber"] - 1
+ });
+ WebInspector.ProfileNode.call(this, callFrame);
+ this.id = node.id;
+ this.self = node.hitCount * sampleTime;
+ this.positionTicks = node.positionTicks;
+ this.deoptReason = node.deoptReason;
}
WebInspector.CPUProfileNode.prototype = {

Powered by Google App Engine
This is Rietveld 408576698