third_party/WebKit/Source/devtools/front_end/components/Linkifier.js - Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expectation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

index 7622d7118600b34d8460b855838683cc61cbc3d7..b4a228f29172a5e724554fe122b377678ff0e67a 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

@@ -224,18 +224,6 @@ WebInspector.Linkifier.prototype = {

/**

- * @param {?WebInspector.Target} target

- * @param {!RuntimeAgent.CallFrame} callFrame

- * @param {string=} classes

- * @return {?Element}

- */

- maybeLinkifyConsoleCallFrameForTracing: function(target, callFrame, classes)

- {

- // TODO(kozyatinskiy): remove this when tracing will migrate to 0-based lineNumber and columnNumber.

- return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes);

- },

- /**

* @param {!WebInspector.Target} target

* @param {!RuntimeAgent.StackTrace} stackTrace

* @param {string=} classes