Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update expectation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
index 73c1f06bf9d5c703bc1c6c4476c4758e7b66d3fa..7bd41ee54faafbe3f6a561c5a50c21b98857377c 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
@@ -221,18 +221,15 @@ WebInspector.SamplingHeapProfileHeader.prototype = {
*/
WebInspector.SamplingHeapProfileNode = function(node)
{
- if (node.callFrame) {
- WebInspector.ProfileNode.call(this, node.callFrame);
- } else {
- // Backward compatibility for old SamplingHeapProfileNode format.
- var frame = /** @type {!RuntimeAgent.CallFrame} */(node);
- WebInspector.ProfileNode.call(this, {
- functionName: frame.functionName,
- scriptId: frame.scriptId, url: frame.url,
- lineNumber: frame.lineNumber - 1,
- columnNumber: frame.columnNumber - 1
- });
- }
+ var callFrame = node.callFrame || /** @type {!RuntimeAgent.CallFrame} */ ({
+ // Backward compatibility for old CpuProfileNode format.
+ functionName: node["functionName"],
+ scriptId: node["scriptId"],
+ url: node["url"],
+ lineNumber: node["lineNumber"] - 1,
+ columnNumber: node["columnNumber"] - 1
+ });
+ WebInspector.ProfileNode.call(this, callFrame);
this.self = node.selfSize;
}

Powered by Google App Engine
This is Rietveld 408576698