third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js - Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js

Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expectation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js

index ccb1a4d09334b8416c9f91bd765a7dd0d1e9c87a..8a38845e9b3502d079f226050831ee0da935583c 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js

@@ -447,7 +447,7 @@ WebInspector.TracingModel.Event = function(categories, name, phase, startTime, t

this.warning = null;

/** @type {?WebInspector.TracingModel.Event} */

this.initiator = null;

- /** @type {?Array.<!RuntimeAgent.CallFrame>} */

+ /** @type {?Array<!RuntimeAgent.CallFrame>} */

this.stackTrace = null;

/** @type {?Element} */

this.previewElement = null;