third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp - Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Issue 2169153002: DevTools: make all timeline trace events use 0-based line numbers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expectation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html ('k') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

index 7caffe4c1889c1ec941befbae8b799e9c7f6d262..9390e994fd5e35426b8a65cd65dbb56e61bde6db 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

@@ -726,8 +726,8 @@ std::unique_ptr<TracedValue> InspectorFunctionCallEvent::data(ExecutionContext*

value->setString("functionName", toCoreString(functionName.As<v8::String>()));

std::unique_ptr<SourceLocation> location = SourceLocation::fromFunction(originalFunction);

value->setString("scriptId", String::number(location->scriptId()));

- value->setString("scriptName", location->url());

- value->setInteger("scriptLine", location->lineNumber());

+ value->setString("url", location->url());

+ value->setInteger("lineNumber", location->lineNumber());

return value;

}