Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2161253003: Revert of PaintChunk::id (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
chrishtr, Xianzhu, pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PaintChunk::id (patchset #10 id:180001 of https://codereview.chromium.org/2116693002/ ) Reason for revert: Test failures on WebKit Win x64 Builder (dbg) since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/89039. failures: PaintChunkerTest.BuildChunksFromNestedTransforms PaintChunkerTest.ChangingPropertiesWithoutItems PaintChunkerTest.SingleNonEmptyRange PaintChunkerTest.CreatesSeparateChunksWhenRequested PaintChunkerTest.ChunkIds PaintChunkerTest.SamePropertiesTwiceCombineIntoOneChunk PaintChunkerTest.ChunkIdsSkippingCache PaintChunkerTest.BuildMultipleChunksWithSinglePropertyChanging PaintChunkerTest.CanRewindDisplayItemIndex PaintChunkerTest.BuildMultipleChunksWithDifferentPropertyChanges Original issue's description: > PaintChunk::id > > The id will be used in rasterization paint invalidation to match old > and new paint chunks. It can be also used in incremental layerization. > > BUG=510908 > > Committed: https://crrev.com/5426e435a6a1c6761b7d9565f769fcde10e7b99c > Cr-Commit-Position: refs/heads/master@{#406461} TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510908 Committed: https://crrev.com/3a9f8efd422ed8a943280774b3afc31fbb1f05af Cr-Commit-Position: refs/heads/master@{#406479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -439 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 3 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h View 4 chunks +2 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunker.h View 3 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunker.cpp View 4 chunks +4 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp View 4 chunks +111 lines, -201 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 6 chunks +17 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScopedPaintChunkProperties.h View 2 chunks +3 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/FakeDisplayItemClient.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hayato
Created Revert of PaintChunk::id
4 years, 5 months ago (2016-07-20 04:18:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161253003/1
4 years, 5 months ago (2016-07-20 04:18:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 04:21:27 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:24:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a9f8efd422ed8a943280774b3afc31fbb1f05af
Cr-Commit-Position: refs/heads/master@{#406479}

Powered by Google App Engine
This is Rietveld 408576698