[DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

[DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

This includes RemoteObject, StackTrace and SearchMatch. Each API class has toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG=580337
Committed: https://crrev.com/4e19044900929958a03fc2d5c07cb2cc5aab47ff
Cr-Commit-Position: refs/heads/master@{#407375}

[dgozman, 2016-07-17 00:07:54]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-17 00:08:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-17 01:31:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-17 01:31:43]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-17 03:09:36]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-07-17 03:09:37]

Could you please take a look?

[dgozman, 2016-07-17 19:33:09]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-17 19:33:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-17 20:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-17 20:59:50]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-18 17:01:51]

Description was changed from

==========
[DevTools] Replace generated protocol classes with explicit ones in
v8_inspector/public.

This include V8RemoteObject, V8StackTrace and V8SearchMatch. Each class
toJSONString() method.
In blink agents, we wrap this string with SerializedValue and store opaque
string as is.

The only last remaning usage of inspector_protocol is toProtocolValue, which
will be removed next.

BUG=none
==========

to

==========
[DevTools] Replace generated protocol classes with explicit ones in
v8_inspector/public.

This include V8RemoteObject, V8StackTrace and V8SearchMatch. Each class
toJSONString() method.
In blink agents, we wrap this string with SerializedValue and store opaque
string as is.

The only last remaning usage of inspector_protocol is toProtocolValue, which
will be removed next.

BUG=580337
==========

[dgozman, 2016-07-21 21:21:16]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-07-21 21:21:17]

Ready for review. Please take a look!

[pfeldman, 2016-07-22 18:02:40]

lgtm

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/SourceLocation.h (right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/SourceLocation.h:56:
std::unique_ptr<protocol::Runtime::Exported::StackTrace> buildInspectorObject()
const;
Runtime::API::StackTrace

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:524: * @this
{!WebInspector.RemoteObjectImpl}
While you are here, remove !

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:538: * @this
{!WebInspector.RemoteObjectImpl}
ditto

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
(right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:106:
paths = [os.path.join(output_dirname, name + ".h"), os.path.join(output_dirname,
name + ".cpp")]
If imports have changed, we should regenerate.

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:144: def
patch_full_qualified_refs():
Copy-paste it.

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:171: #
pylint: disable=W0622
While you are so smart...

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template
(right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template:54:
virtual String16 toJSONString() const;
= 0

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
(right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template:27:
#include "{{output_package}}/{{name}}.h"
It should be clear that we explicitly import public domains. Comment?

[dgozman, 2016-07-22 21:21:07]

Description was changed from

==========
[DevTools] Replace generated protocol classes with explicit ones in
v8_inspector/public.

This include V8RemoteObject, V8StackTrace and V8SearchMatch. Each class
toJSONString() method.
In blink agents, we wrap this string with SerializedValue and store opaque
string as is.

The only last remaning usage of inspector_protocol is toProtocolValue, which
will be removed next.

BUG=580337
==========

to

==========
[DevTools] Generate public versions of protocol classes to be exposed in
v8_inspector/public.

This includes RemoteObject, StackTrace and SearchMatch. Each API class has
toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which
allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG=580337
==========

[dgozman, 2016-07-22 21:21:19]

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/SourceLocation.h (right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/SourceLocation.h:56:
std::unique_ptr<protocol::Runtime::Exported::StackTrace> buildInspectorObject()
const;
On 2016/07/22 18:02:39, pfeldman wrote:
> Runtime::API::StackTrace

Done.

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:524: * @this
{!WebInspector.RemoteObjectImpl}
On 2016/07/22 18:02:40, pfeldman wrote:
> While you are here, remove !

Done.

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
(right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:106:
paths = [os.path.join(output_dirname, name + ".h"), os.path.join(output_dirname,
name + ".cpp")]
On 2016/07/22 18:02:40, pfeldman wrote:
> If imports have changed, we should regenerate.

Done.

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:144: def
patch_full_qualified_refs():
On 2016/07/22 18:02:40, pfeldman wrote:
> Copy-paste it.

Done.

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template
(right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template:54:
virtual String16 toJSONString() const;
On 2016/07/22 18:02:40, pfeldman wrote:
> = 0

Done.

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
(right):

https://codereview.chromium.org/2159633002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template:27:
#include "{{output_package}}/{{name}}.h"
On 2016/07/22 18:02:40, pfeldman wrote:
> It should be clear that we explicitly import public domains. Comment?

Done.

[dgozman, 2016-07-22 21:21:26]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-22 21:21:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2159633002/#ps80001
(title: "fixed review comments")

[commit-bot: I haz the power, 2016-07-22 21:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 22:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 22:19:04]

Try jobs failed on following builders:
  win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp...)

[dgozman, 2016-07-23 17:05:47]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-23 17:05:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2159633002/#ps100001
(title: "gyp fix")

[commit-bot: I haz the power, 2016-07-23 17:05:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 17:36:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 17:36:02]

Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[dgozman, 2016-07-23 19:25:41]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-23 19:25:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2159633002/#ps120001
(title: "removed extra files")

[commit-bot: I haz the power, 2016-07-23 19:25:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 21:44:58]

Description was changed from

==========
[DevTools] Generate public versions of protocol classes to be exposed in
v8_inspector/public.

This includes RemoteObject, StackTrace and SearchMatch. Each API class has
toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which
allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG=580337
==========

to

==========
[DevTools] Generate public versions of protocol classes to be exposed in
v8_inspector/public.

This includes RemoteObject, StackTrace and SearchMatch. Each API class has
toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which
allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG=580337
==========

[commit-bot: I haz the power, 2016-07-23 21:45:00]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-23 21:46:25]

Description was changed from

==========
[DevTools] Generate public versions of protocol classes to be exposed in
v8_inspector/public.

This includes RemoteObject, StackTrace and SearchMatch. Each API class has
toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which
allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG=580337
==========

to

==========
[DevTools] Generate public versions of protocol classes to be exposed in
v8_inspector/public.

This includes RemoteObject, StackTrace and SearchMatch. Each API class has
toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which
allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG=580337

Committed: https://crrev.com/4e19044900929958a03fc2d5c07cb2cc5aab47ff
Cr-Commit-Position: refs/heads/master@{#407375}
==========

[commit-bot: I haz the power, 2016-07-23 21:46:26]

Patchset 7 (id:??) landed as
https://crrev.com/4e19044900929958a03fc2d5c07cb2cc5aab47ff
Cr-Commit-Position: refs/heads/master@{#407375}