third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed extra files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/protocol/Runtime.h ('k') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

index 3793814e5fde8c022bde9a27fdb316e0fc6c6fa9..08191abaa717d63e63dafb58424bb89dd82842d0 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

@@ -503,7 +503,7 @@ WebInspector.RemoteObjectImpl.prototype = {

/**

* @param {function(?)} fulfill

* @param {function(*)} reject

- * @this {WebInspector.RemoteObject}

+ * @this {WebInspector.RemoteObjectImpl}

function eventListeners(fulfill, reject)

{

@@ -521,7 +521,7 @@ WebInspector.RemoteObjectImpl.prototype = {

this.target().domdebuggerAgent().getEventListeners(this._objectId, mycallback.bind(this));

/**

- * @this {!WebInspector.RemoteObject}

+ * @this {WebInspector.RemoteObjectImpl}

* @param {?Protocol.Error} error

* @param {!Array<!DOMDebuggerAgent.EventListener>} payloads

@@ -535,7 +535,7 @@ WebInspector.RemoteObjectImpl.prototype = {

}

/**

- * @this {!WebInspector.RemoteObject}

+ * @this {WebInspector.RemoteObjectImpl}

* @param {!DOMDebuggerAgent.EventListener} payload

function createEventListener(payload)

@@ -547,7 +547,7 @@ WebInspector.RemoteObjectImpl.prototype = {

payload.passive,

payload.handler ? this.target().runtimeModel.createRemoteObject(payload.handler) : null,

payload.originalHandler ? this.target().runtimeModel.createRemoteObject(payload.originalHandler) : null,

- WebInspector.DebuggerModel.Location.fromPayload(this._debuggerModel, payload.location),

+ /** @type {!WebInspector.DebuggerModel.Location} */ (this._debuggerModel.createRawLocationByScriptId(payload.scriptId, payload.lineNumber, payload.columnNumber)),

payload.removeFunction ? this.target().runtimeModel.createRemoteObject(payload.removeFunction) : null);

}