third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed extra files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

index bb49a92636b36105e098ff505f056116bf5554a2..8852b4a731125a95277b12b3d680672cda5fb4b0 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

@@ -357,7 +357,7 @@ void InspectorAnimationAgent::setTiming(ErrorString* errorString, const String&

}

-void InspectorAnimationAgent::resolveAnimation(ErrorString* errorString, const String& animationId, std::unique_ptr<protocol::Runtime::RemoteObject>* result)

+void InspectorAnimationAgent::resolveAnimation(ErrorString* errorString, const String& animationId, std::unique_ptr<protocol::Runtime::API::RemoteObject>* result)

{

blink::Animation* animation = assertAnimation(errorString, animationId);

if (!animation)

@@ -375,7 +375,7 @@ void InspectorAnimationAgent::resolveAnimation(ErrorString* errorString, const S

ScriptState::Scope scope(scriptState);

m_v8Session->releaseObjectGroup("animation");

- *result = m_v8Session->wrapObject(scriptState->context(), toV8(animation, scriptState->context()->Global(), scriptState->isolate()), "animation", false);

+ *result = m_v8Session->wrapObject(scriptState->context(), toV8(animation, scriptState->context()->Global(), scriptState->isolate()), "animation");

if (!*result)

*errorString = "Element not associated with a document.";

}