third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed extra files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

index b9f6f8f0918d12234de5378e14c4058a2cb0170c..22e36492c4b31ee7cbc5e6c5591d318c61bab528 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1364,7 +1364,7 @@ void InspectorDOMAgent::getNodeForLocation(ErrorString* errorString, int x, int

*nodeId = pushNodePathToFrontend(node);

}

-void InspectorDOMAgent::resolveNode(ErrorString* errorString, int nodeId, const Maybe<String>& objectGroup, std::unique_ptr<protocol::Runtime::RemoteObject>* result)

+void InspectorDOMAgent::resolveNode(ErrorString* errorString, int nodeId, const Maybe<String>& objectGroup, std::unique_ptr<protocol::Runtime::API::RemoteObject>* result)

{

String objectGroupName = objectGroup.fromMaybe("");

Node* node = nodeForId(nodeId);

@@ -2041,7 +2041,7 @@ void InspectorDOMAgent::getHighlightObjectForTest(ErrorString* errorString, int

*result = highlight.asProtocolValue();

}

-std::unique_ptr<protocol::Runtime::RemoteObject> InspectorDOMAgent::resolveNode(Node* node, const String& objectGroup)

+std::unique_ptr<protocol::Runtime::API::RemoteObject> InspectorDOMAgent::resolveNode(Node* node, const String& objectGroup)

{

Document* document = node->isDocumentNode() ? &node->document() : node->ownerDocument();

LocalFrame* frame = document ? document->frame() : nullptr;

@@ -2053,7 +2053,7 @@ std::unique_ptr<protocol::Runtime::RemoteObject> InspectorDOMAgent::resolveNode(

return nullptr;

ScriptState::Scope scope(scriptState);

- return m_v8Session->wrapObject(scriptState->context(), nodeV8Value(scriptState->context(), node), objectGroup, false);

+ return m_v8Session->wrapObject(scriptState->context(), nodeV8Value(scriptState->context(), node), objectGroup);

}

bool InspectorDOMAgent::pushDocumentUponHandlelessOperation(ErrorString* errorString)