third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed extra files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

index 63b59e8d9009b3777dfe7239a9b02bfa197bf1d8..c9f3137d1d445d1f014f20a15b4f4af0ef5e361e 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

@@ -5,7 +5,9 @@

#ifndef V8StackTraceImpl_h

#define V8StackTraceImpl_h

+#include "platform/inspector_protocol/Allocator.h"

#include "platform/inspector_protocol/Platform.h"

+#include "platform/v8_inspector/protocol/Runtime.h"

#include "platform/v8_inspector/public/V8StackTrace.h"

#include <vector>

@@ -57,6 +59,7 @@ public:

std::unique_ptr<V8StackTrace> isolatedCopy() override;

std::unique_ptr<V8StackTraceImpl> isolatedCopyImpl();

std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail(V8DebuggerImpl*) const;

+ std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectImpl() const;

~V8StackTraceImpl() override;

// V8StackTrace implementation.

@@ -66,7 +69,7 @@ public:

int topColumnNumber() const override;

String16 topScriptId() const override;

String16 topFunctionName() const override;

- std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObject() const override;

+ std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject() const override;

String16 toString() const override;

private: