third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed extra files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

index 21753dac21b98af1dabc3aefd3d3abbdeceb76b7..888c3d7d51cbf466ba684f1d783c1da66b590e84 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

@@ -48,6 +48,8 @@ public:

void discardInjectedScripts();

void reportAllContexts(V8RuntimeAgentImpl*);

void setCustomObjectFormatterEnabled(bool);

+ std::unique_ptr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview);

+ std::unique_ptr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns);

// V8InspectorSession implementation.

void dispatchProtocolMessage(const String16& message) override;

@@ -61,8 +63,7 @@ public:

void stepOver() override;

void releaseObjectGroup(const String16& objectGroup) override;

v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* groupName = nullptr) override;

- std::unique_ptr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview) override;

- std::unique_ptr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns);

+ std::unique_ptr<protocol::Runtime::API::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName) override;

V8InspectorSession::Inspectable* inspectedObject(unsigned num);

static const unsigned kInspectedObjectBufferSize = 5;