Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed extra files Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
index 923a84e92690808285b939989f944e3489655332..9662ba9a7c4db6505b706e48a342a20b01f94a37 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
@@ -10,7 +10,6 @@
#include "platform/v8_inspector/protocol/Console.h"
#include "platform/v8_inspector/protocol/Runtime.h"
#include "platform/v8_inspector/public/V8ConsoleTypes.h"
-#include "platform/v8_inspector/public/V8StackTrace.h"
#include <deque>
#include <v8.h>
@@ -19,7 +18,7 @@ namespace blink {
class InspectedContext;
class V8DebuggerImpl;
class V8InspectorSessionImpl;
-class V8StackTrace;
+class V8StackTraceImpl;
enum class V8MessageOrigin { kConsole, kException, kRevokedException };
@@ -33,7 +32,7 @@ public:
double timestamp,
ConsoleAPIType,
const std::vector<v8::Local<v8::Value>>& arguments,
- std::unique_ptr<V8StackTrace>,
+ std::unique_ptr<V8StackTraceImpl>,
InspectedContext*);
static std::unique_ptr<V8ConsoleMessage> createForException(
@@ -42,7 +41,7 @@ public:
const String16& url,
unsigned lineNumber,
unsigned columnNumber,
- std::unique_ptr<V8StackTrace>,
+ std::unique_ptr<V8StackTraceImpl>,
int scriptId,
v8::Isolate*,
int contextId,
@@ -66,7 +65,7 @@ private:
using Arguments = std::vector<std::unique_ptr<v8::Global<v8::Value>>>;
std::unique_ptr<protocol::Array<protocol::Runtime::RemoteObject>> wrapArguments(V8InspectorSessionImpl*, bool generatePreview) const;
std::unique_ptr<protocol::Runtime::RemoteObject> wrapException(V8InspectorSessionImpl*, bool generatePreview) const;
- void setLocation(const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId);
+ void setLocation(const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTraceImpl>, int scriptId);
V8MessageOrigin m_origin;
double m_timestamp;
@@ -74,7 +73,7 @@ private:
String16 m_url;
unsigned m_lineNumber;
unsigned m_columnNumber;
- std::unique_ptr<V8StackTrace> m_stackTrace;
+ std::unique_ptr<V8StackTraceImpl> m_stackTrace;
int m_scriptId;
int m_contextId;
ConsoleAPIType m_type;

Powered by Google App Engine
This is Rietveld 408576698