Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup interface descriptors to reflect that vectors are part of stores. All stores require a Slot parameter so VectorStoreICTrampolineDescriptor is a new StoreDescriptor. VectorStoreICDescriptor renamed to StoreWithVectorDescriptor. Committed: https://crrev.com/53be25303970574b7d7ee3e3cd417c615d21dac2 Cr-Commit-Position: refs/heads/master@{#37779}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : Addressing comments #

Patch Set 4 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -386 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/code-factory.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/code-stubs.h View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/ic/access-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/ppc/stub-cache-ppc.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/s390/stub-cache-s390.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/x87/stub-cache-x87.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/interface-descriptors.h View 1 2 4 chunks +11 lines, -26 lines 0 comments Download
M src/interface-descriptors.cc View 1 2 24 chunks +39 lines, -47 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
Igor Sheludko
PTAL
4 years, 5 months ago (2016-07-13 19:45:55 UTC) #6
Jakob Kummerow
lgtm https://codereview.chromium.org/2147043002/diff/20001/src/interface-descriptors.cc File src/interface-descriptors.cc (right): https://codereview.chromium.org/2147043002/diff/20001/src/interface-descriptors.cc#newcode134 src/interface-descriptors.cc:134: Isolate* isolate, int paramater_count) { nit: s/mater/meter/. While ...
4 years, 5 months ago (2016-07-14 11:08:05 UTC) #13
Igor Sheludko
https://codereview.chromium.org/2147043002/diff/20001/src/interface-descriptors.cc File src/interface-descriptors.cc (right): https://codereview.chromium.org/2147043002/diff/20001/src/interface-descriptors.cc#newcode134 src/interface-descriptors.cc:134: Isolate* isolate, int paramater_count) { On 2016/07/14 11:08:05, Jakob ...
4 years, 5 months ago (2016-07-14 13:05:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147043002/40001
4 years, 5 months ago (2016-07-14 13:06:11 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/441) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-14 13:07:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147043002/60001
4 years, 5 months ago (2016-07-14 16:37:59 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-14 17:04:29 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 17:04:31 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 17:07:17 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/53be25303970574b7d7ee3e3cd417c615d21dac2
Cr-Commit-Position: refs/heads/master@{#37779}

Powered by Google App Engine
This is Rietveld 408576698