Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: src/x87/code-stubs-x87.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x64/interface-descriptors-x64.cc ('k') | src/x87/interface-descriptors-x87.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x87/code-stubs-x87.cc
diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc
index 8367fad500c839d61e6a8459fc86a4e657f64bf0..6db16b62975800fcb9b36b5558ec729b4fbc86b3 100644
--- a/src/x87/code-stubs-x87.cc
+++ b/src/x87/code-stubs-x87.cc
@@ -3365,13 +3365,13 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
}
void StoreICTrampolineStub::Generate(MacroAssembler* masm) {
- __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister());
+ __ EmitLoadTypeFeedbackVector(StoreWithVectorDescriptor::VectorRegister());
StoreICStub stub(isolate(), state());
stub.GenerateForTrampoline(masm);
}
void KeyedStoreICTrampolineStub::Generate(MacroAssembler* masm) {
- __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister());
+ __ EmitLoadTypeFeedbackVector(StoreWithVectorDescriptor::VectorRegister());
KeyedStoreICStub stub(isolate(), state());
stub.GenerateForTrampoline(masm);
}
@@ -3416,7 +3416,7 @@ static void HandlePolymorphicStoreCase(MacroAssembler* masm, Register receiver,
// found, now call handler.
Register handler = feedback;
- DCHECK(handler.is(VectorStoreICDescriptor::ValueRegister()));
+ DCHECK(handler.is(StoreWithVectorDescriptor::ValueRegister()));
__ mov(handler, FieldOperand(feedback, FixedArray::OffsetOfElementAt(1)));
__ pop(vector);
__ pop(receiver);
@@ -3476,7 +3476,7 @@ static void HandleMonomorphicStoreCase(MacroAssembler* masm, Register receiver,
Register slot, Register weak_cell,
Label* miss) {
// The store ic value is on the stack.
- DCHECK(weak_cell.is(VectorStoreICDescriptor::ValueRegister()));
+ DCHECK(weak_cell.is(StoreWithVectorDescriptor::ValueRegister()));
ExternalReference virtual_register =
ExternalReference::virtual_handler_register(masm->isolate());
@@ -3515,11 +3515,11 @@ static void HandleMonomorphicStoreCase(MacroAssembler* masm, Register receiver,
}
void StoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
- Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // edx
- Register key = VectorStoreICDescriptor::NameRegister(); // ecx
- Register value = VectorStoreICDescriptor::ValueRegister(); // eax
- Register vector = VectorStoreICDescriptor::VectorRegister(); // ebx
- Register slot = VectorStoreICDescriptor::SlotRegister(); // edi
+ Register receiver = StoreWithVectorDescriptor::ReceiverRegister(); // edx
+ Register key = StoreWithVectorDescriptor::NameRegister(); // ecx
+ Register value = StoreWithVectorDescriptor::ValueRegister(); // eax
+ Register vector = StoreWithVectorDescriptor::VectorRegister(); // ebx
+ Register slot = StoreWithVectorDescriptor::SlotRegister(); // edi
Label miss;
__ push(value);
@@ -3680,11 +3680,11 @@ static void HandlePolymorphicKeyedStoreCase(MacroAssembler* masm,
}
void KeyedStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
- Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // edx
- Register key = VectorStoreICDescriptor::NameRegister(); // ecx
- Register value = VectorStoreICDescriptor::ValueRegister(); // eax
- Register vector = VectorStoreICDescriptor::VectorRegister(); // ebx
- Register slot = VectorStoreICDescriptor::SlotRegister(); // edi
+ Register receiver = StoreWithVectorDescriptor::ReceiverRegister(); // edx
+ Register key = StoreWithVectorDescriptor::NameRegister(); // ecx
+ Register value = StoreWithVectorDescriptor::ValueRegister(); // eax
+ Register vector = StoreWithVectorDescriptor::VectorRegister(); // ebx
+ Register slot = StoreWithVectorDescriptor::SlotRegister(); // edi
Label miss;
__ push(value);
« no previous file with comments | « src/x64/interface-descriptors-x64.cc ('k') | src/x87/interface-descriptors-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698