Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: src/ic/mips/stub-cache-mips.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/ic-mips.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 DCHECK(!extra2.is(no_reg)); 103 DCHECK(!extra2.is(no_reg));
104 DCHECK(!extra3.is(no_reg)); 104 DCHECK(!extra3.is(no_reg));
105 105
106 #ifdef DEBUG 106 #ifdef DEBUG
107 // If vector-based ics are in use, ensure that scratch, extra, extra2 and 107 // If vector-based ics are in use, ensure that scratch, extra, extra2 and
108 // extra3 don't conflict with the vector and slot registers, which need 108 // extra3 don't conflict with the vector and slot registers, which need
109 // to be preserved for a handler call or miss. 109 // to be preserved for a handler call or miss.
110 if (IC::ICUseVector(ic_kind_)) { 110 if (IC::ICUseVector(ic_kind_)) {
111 Register vector, slot; 111 Register vector, slot;
112 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) { 112 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) {
113 vector = VectorStoreICDescriptor::VectorRegister(); 113 vector = StoreWithVectorDescriptor::VectorRegister();
114 slot = VectorStoreICDescriptor::SlotRegister(); 114 slot = StoreWithVectorDescriptor::SlotRegister();
115 } else { 115 } else {
116 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC); 116 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC);
117 vector = LoadWithVectorDescriptor::VectorRegister(); 117 vector = LoadWithVectorDescriptor::VectorRegister();
118 slot = LoadWithVectorDescriptor::SlotRegister(); 118 slot = LoadWithVectorDescriptor::SlotRegister();
119 } 119 }
120 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3)); 120 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3));
121 } 121 }
122 #endif 122 #endif
123 123
124 Counters* counters = masm->isolate()->counters(); 124 Counters* counters = masm->isolate()->counters();
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 158 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
159 extra3); 159 extra3);
160 } 160 }
161 161
162 162
163 #undef __ 163 #undef __
164 } // namespace internal 164 } // namespace internal
165 } // namespace v8 165 } // namespace v8
166 166
167 #endif // V8_TARGET_ARCH_MIPS 167 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/mips/ic-mips.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698