Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/interface-descriptors-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 3588 matching lines...) Expand 10 before | Expand all | Expand 10 after
3599 3599
3600 __ bind(&miss); 3600 __ bind(&miss);
3601 KeyedLoadIC::GenerateMiss(masm); 3601 KeyedLoadIC::GenerateMiss(masm);
3602 3602
3603 __ bind(&load_smi_map); 3603 __ bind(&load_smi_map);
3604 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex); 3604 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex);
3605 __ jmp(&compare_map); 3605 __ jmp(&compare_map);
3606 } 3606 }
3607 3607
3608 void StoreICTrampolineStub::Generate(MacroAssembler* masm) { 3608 void StoreICTrampolineStub::Generate(MacroAssembler* masm) {
3609 __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister()); 3609 __ EmitLoadTypeFeedbackVector(StoreWithVectorDescriptor::VectorRegister());
3610 StoreICStub stub(isolate(), state()); 3610 StoreICStub stub(isolate(), state());
3611 stub.GenerateForTrampoline(masm); 3611 stub.GenerateForTrampoline(masm);
3612 } 3612 }
3613 3613
3614 void KeyedStoreICTrampolineStub::Generate(MacroAssembler* masm) { 3614 void KeyedStoreICTrampolineStub::Generate(MacroAssembler* masm) {
3615 __ EmitLoadTypeFeedbackVector(VectorStoreICDescriptor::VectorRegister()); 3615 __ EmitLoadTypeFeedbackVector(StoreWithVectorDescriptor::VectorRegister());
3616 KeyedStoreICStub stub(isolate(), state()); 3616 KeyedStoreICStub stub(isolate(), state());
3617 stub.GenerateForTrampoline(masm); 3617 stub.GenerateForTrampoline(masm);
3618 } 3618 }
3619 3619
3620 void StoreICStub::Generate(MacroAssembler* masm) { GenerateImpl(masm, false); } 3620 void StoreICStub::Generate(MacroAssembler* masm) { GenerateImpl(masm, false); }
3621 3621
3622 void StoreICStub::GenerateForTrampoline(MacroAssembler* masm) { 3622 void StoreICStub::GenerateForTrampoline(MacroAssembler* masm) {
3623 GenerateImpl(masm, true); 3623 GenerateImpl(masm, true);
3624 } 3624 }
3625 3625
3626 void StoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 3626 void StoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
3627 Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // r1 3627 Register receiver = StoreWithVectorDescriptor::ReceiverRegister(); // r1
3628 Register key = VectorStoreICDescriptor::NameRegister(); // r2 3628 Register key = StoreWithVectorDescriptor::NameRegister(); // r2
3629 Register vector = VectorStoreICDescriptor::VectorRegister(); // r3 3629 Register vector = StoreWithVectorDescriptor::VectorRegister(); // r3
3630 Register slot = VectorStoreICDescriptor::SlotRegister(); // r4 3630 Register slot = StoreWithVectorDescriptor::SlotRegister(); // r4
3631 DCHECK(VectorStoreICDescriptor::ValueRegister().is(r0)); // r0 3631 DCHECK(StoreWithVectorDescriptor::ValueRegister().is(r0)); // r0
3632 Register feedback = r5; 3632 Register feedback = r5;
3633 Register receiver_map = r6; 3633 Register receiver_map = r6;
3634 Register scratch1 = r9; 3634 Register scratch1 = r9;
3635 3635
3636 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot)); 3636 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot));
3637 __ ldr(feedback, FieldMemOperand(feedback, FixedArray::kHeaderSize)); 3637 __ ldr(feedback, FieldMemOperand(feedback, FixedArray::kHeaderSize));
3638 3638
3639 // Try to quickly handle the monomorphic case without knowing for sure 3639 // Try to quickly handle the monomorphic case without knowing for sure
3640 // if we have a weak cell in feedback. We do know it's safe to look 3640 // if we have a weak cell in feedback. We do know it's safe to look
3641 // at WeakCell::kValueOffset. 3641 // at WeakCell::kValueOffset.
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
3735 __ bind(&prepare_next); 3735 __ bind(&prepare_next);
3736 __ add(pointer_reg, pointer_reg, Operand(kPointerSize * 3)); 3736 __ add(pointer_reg, pointer_reg, Operand(kPointerSize * 3));
3737 __ cmp(pointer_reg, too_far); 3737 __ cmp(pointer_reg, too_far);
3738 __ b(lt, &next_loop); 3738 __ b(lt, &next_loop);
3739 3739
3740 // We exhausted our array of map handler pairs. 3740 // We exhausted our array of map handler pairs.
3741 __ jmp(miss); 3741 __ jmp(miss);
3742 } 3742 }
3743 3743
3744 void KeyedStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 3744 void KeyedStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {
3745 Register receiver = VectorStoreICDescriptor::ReceiverRegister(); // r1 3745 Register receiver = StoreWithVectorDescriptor::ReceiverRegister(); // r1
3746 Register key = VectorStoreICDescriptor::NameRegister(); // r2 3746 Register key = StoreWithVectorDescriptor::NameRegister(); // r2
3747 Register vector = VectorStoreICDescriptor::VectorRegister(); // r3 3747 Register vector = StoreWithVectorDescriptor::VectorRegister(); // r3
3748 Register slot = VectorStoreICDescriptor::SlotRegister(); // r4 3748 Register slot = StoreWithVectorDescriptor::SlotRegister(); // r4
3749 DCHECK(VectorStoreICDescriptor::ValueRegister().is(r0)); // r0 3749 DCHECK(StoreWithVectorDescriptor::ValueRegister().is(r0)); // r0
3750 Register feedback = r5; 3750 Register feedback = r5;
3751 Register receiver_map = r6; 3751 Register receiver_map = r6;
3752 Register scratch1 = r9; 3752 Register scratch1 = r9;
3753 3753
3754 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot)); 3754 __ add(feedback, vector, Operand::PointerOffsetFromSmiKey(slot));
3755 __ ldr(feedback, FieldMemOperand(feedback, FixedArray::kHeaderSize)); 3755 __ ldr(feedback, FieldMemOperand(feedback, FixedArray::kHeaderSize));
3756 3756
3757 // Try to quickly handle the monomorphic case without knowing for sure 3757 // Try to quickly handle the monomorphic case without knowing for sure
3758 // if we have a weak cell in feedback. We do know it's safe to look 3758 // if we have a weak cell in feedback. We do know it's safe to look
3759 // at WeakCell::kValueOffset. 3759 // at WeakCell::kValueOffset.
(...skipping 1469 matching lines...) Expand 10 before | Expand all | Expand 10 after
5229 CallApiFunctionAndReturn(masm, api_function_address, thunk_ref, 5229 CallApiFunctionAndReturn(masm, api_function_address, thunk_ref,
5230 kStackUnwindSpace, NULL, return_value_operand, NULL); 5230 kStackUnwindSpace, NULL, return_value_operand, NULL);
5231 } 5231 }
5232 5232
5233 #undef __ 5233 #undef __
5234 5234
5235 } // namespace internal 5235 } // namespace internal
5236 } // namespace v8 5236 } // namespace v8
5237 5237
5238 #endif // V8_TARGET_ARCH_ARM 5238 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/interface-descriptors-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698