Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/access-compiler.cc ('k') | src/ic/arm/ic-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 // Jump to stub. 327 // Jump to stub.
328 CallApiCallbackStub stub(isolate, is_store, call_data_undefined, 328 CallApiCallbackStub stub(isolate, is_store, call_data_undefined,
329 !optimization.is_constant_call()); 329 !optimization.is_constant_call());
330 __ TailCallStub(&stub); 330 __ TailCallStub(&stub);
331 } 331 }
332 332
333 333
334 static void StoreIC_PushArgs(MacroAssembler* masm) { 334 static void StoreIC_PushArgs(MacroAssembler* masm) {
335 __ Push(StoreDescriptor::ReceiverRegister(), StoreDescriptor::NameRegister(), 335 __ Push(StoreDescriptor::ReceiverRegister(), StoreDescriptor::NameRegister(),
336 StoreDescriptor::ValueRegister(), 336 StoreDescriptor::ValueRegister(),
337 VectorStoreICDescriptor::SlotRegister(), 337 StoreWithVectorDescriptor::SlotRegister(),
338 VectorStoreICDescriptor::VectorRegister()); 338 StoreWithVectorDescriptor::VectorRegister());
339 } 339 }
340 340
341 341
342 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) { 342 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) {
343 StoreIC_PushArgs(masm); 343 StoreIC_PushArgs(masm);
344 344
345 // The slow case calls into the runtime to complete the store without causing 345 // The slow case calls into the runtime to complete the store without causing
346 // an IC miss that would otherwise cause a transition to the generic stub. 346 // an IC miss that would otherwise cause a transition to the generic stub.
347 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow); 347 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
348 } 348 }
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
697 // Return the generated code. 697 // Return the generated code.
698 return GetCode(kind(), name); 698 return GetCode(kind(), name);
699 } 699 }
700 700
701 701
702 #undef __ 702 #undef __
703 } // namespace internal 703 } // namespace internal
704 } // namespace v8 704 } // namespace v8
705 705
706 #endif // V8_TARGET_ARCH_ARM 706 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/access-compiler.cc ('k') | src/ic/arm/ic-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698