[DevTools] make Runtime.CallFrame 0-based

[DevTools] make Runtime.CallFrame 0-based

Next steps:
- make profiler's types 0-based
- make backend Stack Trace 0-based
- console message 0-based

R=dgozman@chromium.org
BUG=591496
Committed: https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d
Cr-Commit-Position: refs/heads/master@{#404923}

[kozy, 2016-07-12 02:35:27]

Description was changed from

==========
[DevTools] make Runtime.CallFrame 0-based

Next steps:
- make profiler's types 0-based
- make backend Stack Trace 0-based

R=dgozman@chromium.org
BUG=591496
==========

to

==========
[DevTools] make Runtime.CallFrame 0-based

Next steps:
- make profiler's types 0-based
- make backend Stack Trace 0-based
- console message 0-based

R=dgozman@chromium.org
BUG=591496
==========

[kozy, 2016-07-12 17:07:28]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-07-12 17:07:34]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-07-12 17:28:34]

Dmitry, please take a look!

[dgozman, 2016-07-12 18:34:00]

lgtm

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
(right):

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js:93:
if (callFrame && callFrame.hasOwnProperty("columnNumber"))
It's not optional.

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
(right):

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp:89:
.setLineNumber(m_lineNumber - 1)
Not sure whether m_lineNumber can be zero. Could you please double-check?

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:155: { "name":
"lineNumber", "type": "integer", "description": "JavaScript script line number.
0-based." },
number (0-based).

[kozy, 2016-07-12 19:14:49]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-07-12 19:14:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2145483002/#ps20001
(title: "a")

[kozy, 2016-07-12 19:14:57]

all done

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
(right):

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js:93:
if (callFrame && callFrame.hasOwnProperty("columnNumber"))
On 2016/07/12 18:34:00, dgozman wrote:
> It's not optional.

Done.

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
(right):

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp:89:
.setLineNumber(m_lineNumber - 1)
On 2016/07/12 18:34:00, dgozman wrote:
> Not sure whether m_lineNumber can be zero. Could you please double-check?

It's 1-based but it could be omitted when we don't request information about
line and column, I added DCHECK to Frame constructor.

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2145483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:155: { "name":
"lineNumber", "type": "integer", "description": "JavaScript script line number.
0-based." },
On 2016/07/12 18:34:00, dgozman wrote:
> number (0-based).

Done.

[commit-bot: I haz the power, 2016-07-12 19:16:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 21:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:19:11]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[kozy, 2016-07-12 23:07:32]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-07-12 23:10:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:42:55]

Description was changed from

==========
[DevTools] make Runtime.CallFrame 0-based

Next steps:
- make profiler's types 0-based
- make backend Stack Trace 0-based
- console message 0-based

R=dgozman@chromium.org
BUG=591496
==========

to

==========
[DevTools] make Runtime.CallFrame 0-based

Next steps:
- make profiler's types 0-based
- make backend Stack Trace 0-based
- console message 0-based

R=dgozman@chromium.org
BUG=591496
==========

[commit-bot: I haz the power, 2016-07-13 02:42:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 02:45:42]

Description was changed from

==========
[DevTools] make Runtime.CallFrame 0-based

Next steps:
- make profiler's types 0-based
- make backend Stack Trace 0-based
- console message 0-based

R=dgozman@chromium.org
BUG=591496
==========

to

==========
[DevTools] make Runtime.CallFrame 0-based

Next steps:
- make profiler's types 0-based
- make backend Stack Trace 0-based
- console message 0-based

R=dgozman@chromium.org
BUG=591496

Committed: https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d
Cr-Commit-Position: refs/heads/master@{#404923}
==========

[commit-bot: I haz the power, 2016-07-13 02:45:43]

Patchset 2 (id:??) landed as
https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d
Cr-Commit-Position: refs/heads/master@{#404923}