third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp - Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

index 5c79b5784678c10dc2b9e24cffebf5c2be8cbec7..e7fb57a0baa048ecb00a82f44cbf68c4dcc60aad 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

@@ -72,6 +72,8 @@ V8StackTraceImpl::Frame::Frame(const String16& functionName, const String16& scr

, m_lineNumber(lineNumber)

, m_columnNumber(column)

{

+ DCHECK(m_lineNumber != v8::Message::kNoLineNumberInfo);

+ DCHECK(m_columnNumber != v8::Message::kNoColumnInfo);

}

V8StackTraceImpl::Frame::~Frame()

@@ -86,8 +88,8 @@ std::unique_ptr<protocol::Runtime::CallFrame> V8StackTraceImpl::Frame::buildInsp

.setFunctionName(m_functionName)

.setScriptId(m_scriptId)

.setUrl(m_scriptName)

- .setLineNumber(m_lineNumber)

- .setColumnNumber(m_columnNumber)

+ .setLineNumber(m_lineNumber - 1)

+ .setColumnNumber(m_columnNumber - 1)

.build();

}