third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index d374d3cd8f6b1b788cdac9f639ce42f9cd1ddc31..b8a51e4b0ea1dfa023f935c48bd5d31bccb4ca50 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -619,7 +619,7 @@ WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, tar

function linkifyTopCallFrame()

{

var frame = WebInspector.TimelineUIUtils.topStackFrame(event);

- return frame ? linkifier.linkifyConsoleCallFrame(target, frame, "timeline-details") : null;

+ return frame ? linkifier.linkifyConsoleCallFrameForTimeline(target, frame, "timeline-details") : null;

}

@@ -996,7 +996,7 @@ WebInspector.TimelineUIUtils.buildNetworkRequestDetails = function(request, mode

var sendRequest = request.children[0];

var topFrame = WebInspector.TimelineUIUtils.topStackFrame(sendRequest);

if (topFrame) {

- contentHelper.appendElementRow(title, linkifier.linkifyConsoleCallFrame(target, topFrame));

+ contentHelper.appendElementRow(title, linkifier.linkifyConsoleCallFrameForTimeline(target, topFrame));

} else if (sendRequest.initiator) {

var initiatorURL = WebInspector.TimelineUIUtils.eventURL(sendRequest.initiator);

if (initiatorURL)

@@ -1241,7 +1241,7 @@ WebInspector.TimelineUIUtils.InvalidationsGroupElement.prototype = {

var stack = title.createChild("span", "monospace");

stack.createChild("span").textContent = WebInspector.beautifyFunctionName(topFrame.functionName);

stack.createChild("span").textContent = " @ ";

- stack.createChild("span").appendChild(this._contentHelper.linkifier().linkifyConsoleCallFrame(target, topFrame));

+ stack.createChild("span").appendChild(this._contentHelper.linkifier().linkifyConsoleCallFrameForTimeline(target, topFrame));

}

return title;