third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js - Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

index 4fd2517be0905fb301d319ad099009580cdbbb85..8f42a3be2237c3e773331712168019f706684332 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

@@ -349,8 +349,7 @@ WebInspector.CPUProfileView.NodeFormatter.prototype = {

linkifyNode: function(node)

{

- var callFrame = node.profileNode.frame;

- return this._profileView.linkifier().linkifyConsoleCallFrame(this._profileView.target(), callFrame, "profile-node-file");

+ return this._profileView.linkifier().linkifyConsoleCallFrameForTimeline(this._profileView.target(), node.profileNode.frame, "profile-node-file");

}

@@ -478,9 +477,8 @@ WebInspector.CPUFlameChartDataProvider.prototype = {

var totalTime = millisecondsToString(timelineData.entryTotalTimes[entryIndex]);

pushEntryInfoRow(WebInspector.UIString("Self time"), selfTime);

pushEntryInfoRow(WebInspector.UIString("Total time"), totalTime);

- var callFrame = /** @type {!RuntimeAgent.CallFrame} */ (node);

var linkifier = new WebInspector.Linkifier();

- var text = linkifier.linkifyConsoleCallFrame(this._target, callFrame).textContent;

+ var text = linkifier.linkifyConsoleCallFrameForTimeline(this._target, node).textContent;

linkifier.dispose();

pushEntryInfoRow(WebInspector.UIString("URL"), text);

pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.secondsToString(node.selfTime / 1000, true));