Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
index 67fe2cd8e98be304d61dc18ee9f5dcfa5cc350a2..64d51b19cce8c139325df711960a086dac639bcc 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -98,16 +98,6 @@ WebInspector.DebuggerModel.BreakReason = {
Other: "other"
}
-/**
- * @param {number=} value
- * @return {number}
- */
-WebInspector.DebuggerModel.fromOneBased = function(value)
-{
- // FIXME(webkit:62725): console stack trace line/column numbers are one-based.
- return value ? value - 1 : 0;
-}
-
WebInspector.DebuggerModel.prototype = {
/**
* @return {boolean}
@@ -581,7 +571,7 @@ WebInspector.DebuggerModel.prototype = {
var rawLocations = [];
for (var frame of frames) {
- var rawLocation = this.createRawLocationByScriptId(frame.scriptId, WebInspector.DebuggerModel.fromOneBased(frame.lineNumber), WebInspector.DebuggerModel.fromOneBased(frame.columnNumber));
+ var rawLocation = this.createRawLocationByScriptId(frame.scriptId, frame.lineNumber, frame.columnNumber);
if (rawLocation)
rawLocations.push(rawLocation);
}

Powered by Google App Engine
This is Rietveld 408576698