[DevTools] make Runtime.CallFrame 0-based

third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8StackTraceImpl.h"
 
 #include "platform/inspector_protocol/Platform.h"
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/V8DebuggerImpl.h"
 #include "platform/v8_inspector/V8StringUtil.h"
@@ skipping 68 matching lines @@
 }
 
 // buildInspectorObject() and SourceLocation's toTracedValue() should set the same fields.
 // If either of them is modified, the other should be also modified.
 std::unique_ptr<protocol::Runtime::CallFrame> V8StackTraceImpl::Frame::buildInspectorObject() const
 {
     return protocol::Runtime::CallFrame::create()
         .setFunctionName(m_functionName)
         .setScriptId(m_scriptId)
         .setUrl(m_scriptName)
-        .setLineNumber(m_lineNumber)
-        .setColumnNumber(m_columnNumber)
+        .setLineNumber(m_lineNumber - 1)

[dgozman, 2016/07/12 18:34:00]

Not sure whether m_lineNumber can be zero. Could you please double-check?

[kozy, 2016/07/12 19:14:57]

It's 1-based but it could be omitted when we don't request information about
line and column, I added DCHECK to Frame constructor.

+        .setColumnNumber(m_columnNumber - 1)
         .build();
 }
 
 V8StackTraceImpl::Frame V8StackTraceImpl::Frame::isolatedCopy() const
 {
     return Frame(m_functionName.isolatedCopy(), m_scriptId.isolatedCopy(), m_scriptName.isolatedCopy(), m_lineNumber, m_columnNumber);
 }
 
 // static
 void V8StackTraceImpl::setCaptureStackTraceForUncaughtExceptions(v8::Isolate* isolate, bool capture)
@@ skipping 160 matching lines @@
         stackTrace.append(':');
         stackTrace.appendNumber(frame.lineNumber());
         stackTrace.append(':');
         stackTrace.appendNumber(frame.columnNumber());
         stackTrace.append(')');
     }
     return stackTrace.toString();
 }
 
 } // namespace blink