third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js - Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

Issue 2145483002: [DevTools] make Runtime.CallFrame 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-document-initiator-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

index 1f346e4dd0315940da3f3e55005702c0a459d8b3..57683134637fb1fd2a91d2ff6ba2e0c1bec23f3a 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

@@ -305,9 +305,7 @@ InspectorTest.captureStackTraceIntoString = function(callFrames, asyncStackTrace

function runtimeCallFramePosition()

{

- var lineNumber = this.lineNumber ? this.lineNumber - 1 : 0;

- var columnNumber = this.columnNumber ? this.columnNumber - 1 : 0;

- return new WebInspector.DebuggerModel.Location(debuggerModel, this.scriptId, lineNumber, columnNumber);

+ return new WebInspector.DebuggerModel.Location(debuggerModel, this.scriptId, this.lineNumber, this.columnNumber);

}

results.push("Call stack:");

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-document-initiator-expected.txt » ('j') | no next file with comments »