Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2144733005: [WIP] cc: Plumb SurfaceId from clients

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, kalyank, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, pfeldman, xlai (Olivia)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] cc: Plumb SurfaceId from clients BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : Plumb SurfaceId from clients #

Patch Set 3 : Rebase + Fix Mac #

Patch Set 4 : Mostly works #

Patch Set 5 : Updated #

Patch Set 6 : Pass client ID to SurfaceFactory #

Patch Set 7 : Move ID Management to SurfaceFactory #

Patch Set 8 : Make SurfaceManager methods private #

Patch Set 9 : Compiles #

Patch Set 10 : Drop client_id in CompositorOutputSurface #

Patch Set 11 : All cc_unittests pass + Chrome OS runs fine #

Patch Set 12 : All RenderWidgetHostViewAura tests pass #

Patch Set 13 : Cleanup SurfaceManager #

Patch Set 14 : Ensure only SurfaceFactoy and tests can update hierarchy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -462 lines) Patch
M ash/sysui/stub_context_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/stub_context_factory.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M ash/wm/window_animations.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -4 lines 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 2 3 4 5 6 chunks +6 lines, -6 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +13 lines, -15 lines 0 comments Download
M cc/surfaces/surface_display_output_surface_unittest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +1 line, -3 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 2 3 4 5 6 3 chunks +11 lines, -1 line 0 comments Download
M cc/surfaces/surface_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +24 lines, -2 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +14 lines, -15 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 1 2 3 4 5 12 chunks +13 lines, -11 lines 0 comments Download
M cc/surfaces/surface_id_allocator.h View 1 2 3 4 1 chunk +0 lines, -13 lines 0 comments Download
M cc/surfaces/surface_id_allocator.cc View 1 2 3 4 1 chunk +2 lines, -11 lines 0 comments Download
M cc/surfaces/surface_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +28 lines, -23 lines 0 comments Download
M cc/surfaces/surface_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +12 lines, -17 lines 0 comments Download
M cc/surfaces/surface_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 chunks +52 lines, -90 lines 0 comments Download
M cc/surfaces/surface_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surfaces_pixeltest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/test_delegating_output_surface.cc View 1 2 3 4 5 6 7 4 chunks +3 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/surface.cc View 1 2 3 4 5 6 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -7 lines 0 comments Download
M content/browser/compositor/reflector_impl.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/surface_utils.h View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M content/browser/compositor/surface_utils.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 2 3 4 5 6 7 7 chunks +35 lines, -38 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 2 3 4 5 6 7 8 3 chunks +24 lines, -22 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 chunks +38 lines, -26 lines 0 comments Download
M content/browser/renderer_host/offscreen_canvas_surface_impl.cc View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 33 chunks +79 lines, -44 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 2 3 4 5 6 7 8 9 5 chunks +20 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_view_host.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M services/ui/gpu/display_compositor/compositor_frame_sink_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M services/ui/surfaces/display_compositor.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -8 lines 0 comments Download
M services/ui/ws/server_window_surface.h View 1 2 3 4 5 6 7 3 chunks +1 line, -6 lines 0 comments Download
M services/ui/ws/server_window_surface.cc View 1 2 3 4 5 6 7 3 chunks +10 lines, -21 lines 0 comments Download
M services/ui/ws/server_window_surface_manager.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -8 lines 0 comments Download
M ui/compositor/compositor.h View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -1 line 0 comments Download
M ui/compositor/compositor_observer.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +11 lines, -0 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -7 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (14 generated)
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-14 12:34:00 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 23:29:30 UTC) #13
Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

Powered by Google App Engine
This is Rietveld 408576698