Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: cc/surfaces/surface_aggregator_unittest.cc

Issue 2144733005: [WIP] cc: Plumb SurfaceId from clients Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ensure only SurfaceFactoy and tests can update hierarchy Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_aggregator_perftest.cc ('k') | cc/surfaces/surface_display_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_aggregator_unittest.cc
diff --git a/cc/surfaces/surface_aggregator_unittest.cc b/cc/surfaces/surface_aggregator_unittest.cc
index 804620a35bba4d37149d4a2591b425e6bd3bf139..4520c46d40be6df9bd2198f430ba8b241f4def01 100644
--- a/cc/surfaces/surface_aggregator_unittest.cc
+++ b/cc/surfaces/surface_aggregator_unittest.cc
@@ -68,7 +68,7 @@ class EmptySurfaceFactoryClient : public SurfaceFactoryClient {
class SurfaceAggregatorTest : public testing::Test {
public:
explicit SurfaceAggregatorTest(bool use_damage_rect)
- : factory_(&manager_, &empty_client_),
+ : factory_(kArbitraryClientId, &manager_, &empty_client_),
aggregator_(&manager_, NULL, use_damage_rect) {}
SurfaceAggregatorTest() : SurfaceAggregatorTest(false) {}
@@ -1919,7 +1919,7 @@ void SubmitCompositorFrameWithResources(ResourceId* resource_ids,
TEST_F(SurfaceAggregatorWithResourcesTest, TakeResourcesOneSurface) {
ResourceTrackingSurfaceFactoryClient client;
- SurfaceFactory factory(&manager_, &client);
+ SurfaceFactory factory(kArbitraryClientId, &manager_, &client);
SurfaceId surface_id(kArbitraryClientId, 7u, 0);
factory.Create(surface_id);
@@ -1949,7 +1949,7 @@ TEST_F(SurfaceAggregatorWithResourcesTest, TakeResourcesOneSurface) {
TEST_F(SurfaceAggregatorWithResourcesTest, TakeInvalidResources) {
ResourceTrackingSurfaceFactoryClient client;
- SurfaceFactory factory(&manager_, &client);
+ SurfaceFactory factory(kArbitraryClientId, &manager_, &client);
SurfaceId surface_id(kArbitraryClientId, 7u, 0);
factory.Create(surface_id);
@@ -1983,7 +1983,7 @@ TEST_F(SurfaceAggregatorWithResourcesTest, TakeInvalidResources) {
TEST_F(SurfaceAggregatorWithResourcesTest, TwoSurfaces) {
ResourceTrackingSurfaceFactoryClient client;
- SurfaceFactory factory(&manager_, &client);
+ SurfaceFactory factory(kArbitraryClientId, &manager_, &client);
SurfaceId surface1_id(kArbitraryClientId, 7u, 0);
factory.Create(surface1_id);
@@ -2024,7 +2024,7 @@ TEST_F(SurfaceAggregatorWithResourcesTest, TwoSurfaces) {
// resources.
TEST_F(SurfaceAggregatorWithResourcesTest, InvalidChildSurface) {
ResourceTrackingSurfaceFactoryClient client;
- SurfaceFactory factory(&manager_, &client);
+ SurfaceFactory factory(kArbitraryClientId, &manager_, &client);
SurfaceId root_surface_id(kArbitraryClientId, 7u, 0);
factory.Create(root_surface_id);
SurfaceId middle_surface_id(kArbitraryClientId, 8u, 0);
@@ -2072,7 +2072,7 @@ TEST_F(SurfaceAggregatorWithResourcesTest, InvalidChildSurface) {
TEST_F(SurfaceAggregatorWithResourcesTest, SecureOutputTexture) {
ResourceTrackingSurfaceFactoryClient client;
- SurfaceFactory factory(&manager_, &client);
+ SurfaceFactory factory(kArbitraryClientId, &manager_, &client);
SurfaceId surface1_id(kArbitraryClientId, 7u, 0);
factory.Create(surface1_id);
« no previous file with comments | « cc/surfaces/surface_aggregator_perftest.cc ('k') | cc/surfaces/surface_display_output_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698