content/browser/frame_host/render_widget_host_view_guest_unittest.cc - Issue 2144733005: [WIP] cc: Plumb SurfaceId from clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest_unittest.cc

Issue 2144733005: [WIP] cc: Plumb SurfaceId from clients Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ensure only SurfaceFactoy and tests can update hierarchy Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_guest.cc ('k') | content/browser/renderer_host/delegated_frame_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest_unittest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_guest_unittest.cc b/content/browser/frame_host/render_widget_host_view_guest_unittest.cc

index 47e457cbee04ff541860844cd9bfcd039d8c436a..764051b871dc827cb2b7c44f8d3ad4eae3254486 100644

--- a/content/browser/frame_host/render_widget_host_view_guest_unittest.cc

+++ b/content/browser/frame_host/render_widget_host_view_guest_unittest.cc

@@ -239,7 +239,8 @@ TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) {

browser_plugin_guest_->set_attached(true);

view_->OnSwapCompositorFrame(

- 0, CreateDelegatedFrame(scale_factor, view_size, view_rect));

+ 0, cc::SurfaceId(),

+ CreateDelegatedFrame(scale_factor, view_size, view_rect));

cc::SurfaceId id = surface_id();

if (!id.is_null()) {

@@ -262,7 +263,8 @@ TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) {

browser_plugin_guest_->set_has_attached_since_surface_set(true);

view_->OnSwapCompositorFrame(

- 0, CreateDelegatedFrame(scale_factor, view_size, view_rect));

+ 0, cc::SurfaceId(),

+ CreateDelegatedFrame(scale_factor, view_size, view_rect));

id = surface_id();

if (!id.is_null()) {

@@ -286,7 +288,8 @@ TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) {

browser_plugin_guest_->ResetTestData();

view_->OnSwapCompositorFrame(

- 0, CreateDelegatedFrame(scale_factor, view_size, view_rect));

+ 0, cc::SurfaceId(),

+ CreateDelegatedFrame(scale_factor, view_size, view_rect));

EXPECT_TRUE(surface_id().is_null());

}